Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellings #742

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Spellings #742

merged 1 commit into from
Jul 26, 2023

Conversation

kunalb
Copy link
Contributor

@kunalb kunalb commented Jul 24, 2023

Summary: TSIA

Differential Revision: D47722348

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47722348

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #742 (ae049c4) into main (d452a8c) will decrease coverage by 1.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   92.80%   91.06%   -1.75%     
==========================================
  Files          96       96              
  Lines        6072     6063       -9     
==========================================
- Hits         5635     5521     -114     
- Misses        437      542     +105     
Flag Coverage Δ
unittests 91.06% <ø> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
torchx/schedulers/api.py 93.39% <ø> (-0.95%) ⬇️
torchx/schedulers/local_scheduler.py 94.19% <ø> (-0.03%) ⬇️
torchx/specs/api.py 98.41% <ø> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Summary:
Pull Request resolved: pytorch#742

TSIA

Reviewed By: manav-a

Differential Revision: D47722348

fbshipit-source-id: d98991229a3677276726448ab86e980f33e84bbc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47722348

Copy link
Contributor

@d4l3k d4l3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the cleanups

@d4l3k d4l3k merged commit a17e427 into pytorch:main Jul 26, 2023
14 of 23 checks passed
KPostOffice pushed a commit to KPostOffice/torchx that referenced this pull request Sep 7, 2023
Summary:
Pull Request resolved: pytorch#742

TSIA

Reviewed By: manav-a

Differential Revision: D47722348

fbshipit-source-id: d98991229a3677276726448ab86e980f33e84bbc
MichaelClifford pushed a commit to project-codeflare/torchx that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: pytorch#742

TSIA

Reviewed By: manav-a

Differential Revision: D47722348

fbshipit-source-id: d98991229a3677276726448ab86e980f33e84bbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants