Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #775 #777

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fixes #775 #777

merged 1 commit into from
Oct 18, 2023

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Oct 17, 2023

passing AppDef metadata to job tags for AWS Batch scheduler

Test plan:

  • updated the unit tests

@azzhipa
fixes pytorch#775
a4ae806 
passing AppDef metadata to job tags for AWS Batch scheduler
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2023
@clumsy clumsy marked this pull request as draft October 17, 2023 18:03
@clumsy clumsy marked this pull request as ready for review October 17, 2023 18:05
@clumsy
Copy link
Contributor Author

clumsy commented Oct 17, 2023

For your consideration, @kiukchung

kiukchung
kiukchung approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@kiukchung kiukchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the PR!

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #777 (a4ae806) into main (13a4787) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          96       96           
  Lines        6098     6098           
=======================================
  Hits         5664     5664           
  Misses        434      434
Flag Coverage Δ
unittests 92.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
torchx/schedulers/aws_batch_scheduler.py 90.31% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@clumsy
Copy link
Contributor Author

clumsy commented Oct 18, 2023

Looks like all checks passed, @kiukchung. Please let me know if there's anything I can do to help merging this. Thanks!

@kiukchung kiukchung merged commit 9421dfa into pytorch:main Oct 18, 2023
24 checks passed
@clumsy clumsy deleted the feature/775 branch October 18, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiukchung kiukchung kiukchung approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clumsy @kiukchung @facebook-github-bot @azzhipa