Move logic from TorchX CLI -> API, so MVAI can call it #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MVAI's "light" is synchronous - you can immediately see the logs for jobs you start. Only "fire" is asynchronous.
TorchX's API, since it's generic, always creates jobs that are asynchronous. Therefore, there isn't a built-in interface for "tailing" the stderr of every started process - just for tailing individual replicas of a given role.
The TorchX CLI's
torchx run
command has implemented this, but its implementation is coupled with the CLI implementations oftorchx run
andtorchx log
.This diff extracts the useful logic into a helper function of the TorchX API
Reviewed By: andywag
Differential Revision: D62463211