Early version of using PHPStan for parsing. #1383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrickkusebauch thank you very much for the contributions you are doing for Deptrac. I still reading all the PRs, but unfortunately I can’t work on Deptrac as much as I would like too. But I might get enough spare time the week before eastern to prepare the new release process, what means new releases will be easier to cut. |
patrickkusebauch
changed the title
Current run on deptrac itself finds new dependencies not found with the old method when calling `parent::method()` by resolving the `parent` to the actual class. There is 10_000 things surely wrong with the implementation that needs fixing in the next passes, there are no tests, BUT, it works. Big thanks to Tomas Votruba for Rector and his blog as it allowed me by example to integrate PHPStan DIC to deptrac.
…ing and leave creating references to dedicated extractors. As a consequence the FileReferenceVisitor code is way more readable now.
…entations. Similar to how PHPStan custom rules work. Also allows us to call extractors only when they apply to the node in question.
|
Please update the git origin for development to https://github.com/qossmic/deptrac-src and reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current run on deptrac itself finds new dependencies not found with the old method when calling
parent::method()by resolving theparentto the actual class.There are 10_000 things surely wrong with the implementation that need fixing in the next passes, there are no tests, BUT, it works.
Big thanks to @TomasVotruba for Rector and his blog as it allowed me by example to integrate PHPStan DIC to deptrac.
While it does not add much on its own, I see how this might allow us to resolve many open issues in the future, like the oldest open issue #449.