Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbolic link to examples #83

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

gastaldi
Copy link
Member

@gastaldi gastaldi commented Aug 3, 2022

@gastaldi gastaldi linked an issue Aug 3, 2022 that may be closed by this pull request
@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

Hm, the maven build didn't like it, let me investigate why

@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

@abelsromero @LightGuard is this a known issue with the asciidoctor maven plugin?

@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

I created asciidoctor/asciidoctor-maven-plugin#588 to track this

@gastaldi

This comment was marked as outdated.

@gastaldi gastaldi force-pushed the main branch 2 times, most recently from c51b3b0 to e76c205 Compare August 3, 2022 15:12
@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

Using @gsmet's example above I managed to make it work (but without compiling, since it would require setting the dependencies and put in the expected packages).

I think we can add the examplesdir attribute in the quarkiverse-parent pom.xml to make configuration easier, WDYT?

@gsmet
Copy link
Member

gsmet commented Aug 3, 2022

I /think/ I included this new stuff in the template.

@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

@gsmet that's right, you did, but https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus-extension/code/quarkiverse/java/docs/pom.tpl.qute.xml#L28 assumes that everything under the examples/ is compilable, which may not be necessarily true

@gastaldi gastaldi force-pushed the main branch 2 times, most recently from 17bfcdb to 75f1e6b Compare August 3, 2022 15:29
@gsmet
Copy link
Member

gsmet commented Aug 3, 2022

Yeah, for me, the whole point of that was to have compilable examples. If not compilable, better add them directly in the doc and not bother about creating external files.

@gastaldi
Copy link
Member Author

gastaldi commented Aug 3, 2022

They are already compiled when the integration tests are executed, so the idea is to just reference them in the docs instead of having it copied somewhere

@abelsromero
Copy link

I answered asciidoctor/asciidoctor-maven-plugin#588 but reading this I am confused. This repo is crearly and Antora module, it doesn't make sense to use the asciidoctor maven plugin unless you are reusing pieces of docs somehow. Which I would not recommend, Antora adds many things on top and we cannot support them unless we build a full reimplementation.

@gsmet
Copy link
Member

gsmet commented Aug 3, 2022

@abelsromero so basically, we are using the Maven plugin to get some local rendering to check the output. Except for that, we don't use it.

And the modules of several repositories are then aggregated into a single Antora website.

So our general aim is to have both outputs working so that people can check the output in their local repo before pushing it.

@abelsromero
Copy link

Thanks @gsmet I'll integrate that into our story, there may be something we can do to support this preview scenario 🙇 .

@michael-simons michael-simons merged commit 4cb74c2 into quarkiverse:main Sep 9, 2022
@michael-simons
Copy link
Contributor

@all-contributors please add @gastaldi for infra

@allcontributors
Copy link
Contributor

@michael-simons

I've put up a pull request to add @gastaldi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs code snippets report an error
4 participants