Add Ramon's Facet Filter & Search Implementation #32
Conversation
|
Reading the review of the original @bloodbare PR, the main blocking point is the panic. @poljar actually mentioned he would rather have the update of tantivy in a separate PR. |
|
A separate PR would have been preferred but at this point getting this over the finish line is more important. |
|
@poljar @fulmicoton Thanks for the feedback! I was actually trying to update to tantivy 0.15.3, but it looks like that's going to be a bit more work, so I think getting this merged and then working on 0.15 makes sense. Going to try and figure out the panics now that you're okay with this for the moment. |
|
Also, is something up with the CI pipeline? I just realized it looks like it ran for the original PR, but it doesn't seem to have run for this one. Or has something just not yet triggered it? I did run the tests locally and they all passed, but wanted to check. |
I think Travis (the CI provider) gave us the boot, we'll need to switch to Github Actions. |
| @@ -277,7 +279,7 @@ impl Index { | |||
| #[staticmethod] | |||
| fn exists(path: &str) -> PyResult<bool> { | |||
| let directory = MmapDirectory::open(path).map_err(to_pyerr)?; | |||
| Ok(tv::Index::exists(&directory)) | |||
| Ok(tv::Index::exists(&directory).unwrap()) | |||
…ions/actions/setup-python-4.5.0 build(deps): bump actions/setup-python from 4.2.0 to 4.5.0
This PR is a clone of @bloodbare's PR, but rebased on the latest commit from the master branch.
Itt upgrades the tantivy version to 0.14.0 and also upgrades the PyO3 version to 0.14.1.
I haven't yet removed the panic, just wanted to make sure we got this to the point that it's just about the same as the original PR first.
Let me know if it looks okay please!