Remove <Delay /> component
#4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4132 +/- ##
==========================================
+ Coverage 37.89% 37.91% +0.02%
==========================================
Files 732 731 -1
Lines 33755 33734 -21
Branches 4979 4979
==========================================
Hits 12790 12790
- Misses 19785 20320 +535
+ Partials 1180 624 -556
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
im not quite sure why to keep it at all given the transitionDelay prop |
|
I don't know what was your intention to use it. If it was just cosmetic and can be replaced with CSS, then I can remove |
|
most likely it was that, yeah |
nl0
previously approved these changes
Oct 1, 2024
nl0
approved these changes
Oct 7, 2024
nl0
added a commit
that referenced
this pull request
Oct 7, 2024
* master: (97 commits) Remove `<Delay />` component (#4132) rewrite SUMMARY (doc reorg) (#4149) Tabulator, Admin: UI for modifying tabulator configs (#4135) Bump debian from `1b0b790` to `3f9e536` in /lambdas/thumbnail (#4158) Bump debian from bullseye-20240904-slim to bullseye-20240926-slim in /lambdas/thumbnail (#4156) Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /catalog (#4151) Bump amazonlinux from 2023.5.20240903.0 to 2023.5.20240916.0 in /s3-proxy (#4152) Edit file / Edit with config helper (#4147) Fix "bad `setState()`" warning (#4150) Update dependency webpack to v5.94.0 [SECURITY] (#4125) Fix `ui.package_description` example (#4146) Bump urllib3 from 1.26.18 to 1.26.19 in /lambdas/s3select (#4140) Move bucket settings to a separate page (#4122) Bump debian from bullseye-20240812-slim to bullseye-20240904-slim in /lambdas/thumbnail (#4131) Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /catalog (#4133) Bump amazonlinux from 2023.5.20240819.0 to 2023.5.20240903.0 in /s3-proxy (#4134) Bump certifi from 2023.7.22 to 2024.7.4 in /lambdas/preview (#4130) Bump zipp from 3.15.0 to 3.19.1 in /lambdas/preview (#4129) Bump cryptography from 42.0.4 to 43.0.1 in /lambdas/indexer (#4128) Ignore line-length lint rule for CHANGELOG (#4127) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
<Delay />component with<... style={{ transitionDelay: '1000ms' }}>