Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency express to v4.20.0 [SECURITY] #4143

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 16, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.19.2 -> 4.20.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.72%. Comparing base (97dda74) to head (5d99901).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4143   +/-   ##
=======================================
  Coverage   37.72%   37.72%           
=======================================
  Files         766      766           
  Lines       35148    35148           
  Branches     5190     5190           
=======================================
  Hits        13258    13258           
  Misses      20658    20658           
  Partials     1232     1232           
Flag Coverage Δ
api-python 91.00% <ø> (ø)
catalog 12.12% <ø> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 7 times, most recently from 62ac7b2 to 4720ad2 Compare September 24, 2024 11:34
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from 3569055 to 5191efa Compare October 7, 2024 13:29
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 11 times, most recently from 69049ae to 2992661 Compare October 11, 2024 09:34
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 2992661 to 5d99901 Compare October 11, 2024 09:47
@nl0 nl0 enabled auto-merge October 11, 2024 09:50
@nl0 nl0 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit 45070e6 Oct 11, 2024
38 checks passed
@nl0 nl0 deleted the renovate/npm-express-vulnerability branch October 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant