Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix cargo clippy issues #2051

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: Fix cargo clippy issues #2051

merged 1 commit into from
Nov 18, 2024
+28 −35

Conversation

larseggert
Copy link
Contributor

No description provided.

@djc
Copy link
Member

djc commented Nov 18, 2024

Are you sticking to nightly clippy for some reason? If so might make sense to have a CI job for that?

djc
djc approved these changes Nov 18, 2024
View reviewed changes
perf/src/bin/perf_client.rs Show resolved Hide resolved
@larseggert
Copy link
Contributor Author

Are you sticking to nightly clippy for some reason? If so might make sense to have a CI job for that?

I just run the Nightly toolchain by default. CI would work but clippy --fix isn't super stable and so this usually requires manual interaction.

Ralith
Ralith approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ralith Ralith added this pull request to the merge queue Nov 18, 2024
Merged via the queue into quinn-rs:main with commit f8b8c50 Nov 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larseggert @djc @Ralith