Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GitHub Actions failing immediately for rcc #345

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

d-hansen
Copy link
Contributor

@d-hansen d-hansen commented Sep 6, 2024

This PR addresses the issue of GitHub Actions failing immediately when running R-CMD-check.yaml (rcc):

Smoke test: stock R
This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Turns out, the yaml script was using actions/upload-artifact@v2 to upload the smoke test SHA artifact. There is no reason not to just use the most recent version of the artifact uploader (v4) for this step.

@d-hansen
Copy link
Contributor Author

d-hansen commented Sep 6, 2024

Sorry I didn't dig deeper to why GitHub Actions was failing in my fork and address this pedantic little error last week (not that I introduced it - it was just that GitHub Actions actually followed through on deprecating v2 when they said they would).

@d-hansen d-hansen changed the title Update R-CMD-check.yaml to address GitHub Actions failing immediately on deprecated actions/upload-artifact@v2 Address GitHub Actions failing immediately for rcc Sep 6, 2024
@krlmlr
Copy link
Member

krlmlr commented Sep 6, 2024

Oh, a brownout? Thanks, good catch! I'm fixing elsewhere and propagate to this repo later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants