Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigrquerystorage is now on CRAN #620

Merged
merged 2 commits into from
Oct 17, 2024
Merged

bigrquerystorage is now on CRAN #620

merged 2 commits into from
Oct 17, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Oct 1, 2024

No description provided.

@hadley
Copy link
Member Author

hadley commented Oct 16, 2024

@meztez this is still failing on R 4.1. Did the install code not make it in the CRAN release?

@hadley hadley changed the title bigrquery storage is now on CRAN bigrquerystorage is now on CRAN Oct 16, 2024
@meztez
Copy link
Contributor

meztez commented Oct 16, 2024

CRAN does not allow external download for installation. I've kept it on GitHub though.

@hadley
Copy link
Member Author

hadley commented Oct 16, 2024

Right. I guess I thought that you'd still include the code because it'll never be run on CRAN, because CRAN doesn't do run test packages on older versions of R. I think otherwise the fix doesn't help much because most people will be building the package from the CRAN version, not the GitHub version.

@meztez
Copy link
Contributor

meztez commented Oct 16, 2024

i will do a re release then, test this hypothesis out

@hadley
Copy link
Member Author

hadley commented Oct 17, 2024

Thanks @meztez!

@meztez
Copy link
Contributor

meztez commented Oct 17, 2024

Released 1.2.1

@hadley
Copy link
Member Author

hadley commented Oct 17, 2024

@meztez looks good. Thanks for all your work on this! I know this feature is going to make a lot of people happy.

@hadley hadley merged commit ebcc762 into main Oct 17, 2024
12 checks passed
@hadley hadley deleted the cran-bigrquerystorage branch October 17, 2024 18:22
@meztez
Copy link
Contributor

meztez commented Oct 17, 2024

What are you talking about? You are the general that made all of this happen. Thank YOU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants