Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos-latest to ci pipeline #229

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Add macos-latest to ci pipeline #229

merged 4 commits into from
Oct 2, 2024

Conversation

ljgray
Copy link
Contributor

@ljgray ljgray commented Nov 18, 2022 •
edited
Loading

@ljgray ljgray requested a review from jrs65 November 18, 2022 00:40
@ljgray ljgray closed this Nov 18, 2022
@ljgray ljgray reopened this Nov 18, 2022
@ljgray ljgray marked this pull request as draft November 18, 2022 00:41
@ljgray
Copy link
Contributor Author

ljgray commented Nov 18, 2022

I'm not familiar with using brew on macos but I think it will have to replace the apt-get step

@ljgray ljgray force-pushed the ci-macos-latest branch 2 times, most recently from a950588 to 2aa0ac6 Compare November 19, 2022 00:14
@ljgray ljgray force-pushed the ci-macos-latest branch 2 times, most recently from 8e7ae2a to e965643 Compare January 13, 2023 23:37
jrs65
jrs65 requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@jrs65 jrs65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this needs to actually run properly first. So let me suggest some changes.

jrs65
jrs65 previously requested changes Jan 25, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@ljgray
Copy link
Contributor Author

ljgray commented Jan 25, 2023

Yes haha I've been having issues getting Brew to install/set up some dependencies properly so I've just kept this as a draft

@ljgray ljgray force-pushed the ci-macos-latest branch 3 times, most recently from b855e39 to 9a9fc22 Compare October 10, 2023 22:21
@ljgray ljgray force-pushed the ci-macos-latest branch 2 times, most recently from 6f5b0c8 to 147c62c Compare May 21, 2024 19:02
@ljgray ljgray force-pushed the ci-macos-latest branch 4 times, most recently from 5e51883 to 1fbaa67 Compare August 8, 2024 16:54
@ljgray ljgray changed the title ci(main): add macos-latest to ci pipeline Add macos-latest to ci pipeline Aug 8, 2024
@ljgray ljgray marked this pull request as ready for review October 2, 2024 13:24
@ljgray ljgray requested a review from ketiltrout October 2, 2024 13:24
ketiltrout
ketiltrout approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@ketiltrout ketiltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

@ketiltrout ketiltrout requested a review from jrs65 October 2, 2024 14:02
@ketiltrout
Copy link
Member

I've updated the list of required checks in the branch protection rules

@ljgray ljgray merged commit 5494000 into master Oct 2, 2024
7 checks passed
@ljgray ljgray deleted the ci-macos-latest branch October 2, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketiltrout ketiltrout ketiltrout approved these changes

@jrs65 jrs65 Awaiting requested review from jrs65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljgray @ketiltrout @jrs65