Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Add ray_io_cluster to all Ray metrics #2524

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Nov 8, 2024

Why are these changes needed?

Both metrics from ServiceMonitor and PodMonitor have the label ray_io_cluster after this PR. Before this PR, only metrics from ServiceMonitor have the label.

Screenshot 2024-11-08 at 10 26 28 AM
Screenshot 2024-11-08 at 10 26 35 AM

Related issue number

Part of #2502

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Signed-off-by: kaihsun <[email protected]>
@kevin85421 kevin85421 merged commit a871314 into ray-project:master Nov 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants