[API Server] Add Ray Job output - start/end time and ray cluster name #2533
+237
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @YQ-Wang (how do I assign people?) |
YQ-Wang
reviewed
Nov 12, 2024
proto/go_client/config.pb.gw.go
Outdated
| @@ -789,7 +789,7 @@ func RegisterImageTemplateServiceHandlerServer(ctx context.Context, mux *runtime | |||
| // RegisterComputeTemplateServiceHandlerFromEndpoint is same as RegisterComputeTemplateServiceHandler but | |||
| // automatically dials to "endpoint" and closes the connection when "ctx" gets done. | |||
| func RegisterComputeTemplateServiceHandlerFromEndpoint(ctx context.Context, mux *runtime.ServeMux, endpoint string, opts []grpc.DialOption) (err error) { | |||
| conn, err := grpc.NewClient(endpoint, opts...) | |||
| conn, err := grpc.Dial(endpoint, opts...) | |||
There was a problem hiding this comment.
I noticed this change last time as well. I manually put it back to the original code.
There was a problem hiding this comment.
Oh ok... Wonder why the generated pb is inconsistent.
|
LGTM |
|
We are currently in KubeCon. I have already approved the CI. I will merge it if CI passes because @YQ-Wang has already approved this API server PR. |
|
@han-steve would you mind taking a look at the lint error? Thanks! |
|
Yep! |
|
@han-steve would you mind fixing the conflict? Thanks! |
Signed-off-by: Steve Han <[email protected]>
|
Done :) |
kevin85421
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding the starttime, endtime, and the rayclustername fields to the api server output to match the status fields on the rayjob CRD.
These fields are useful for displaying the job start/end time information and easily pulling the cluster information. For us, they are also useful for generating the grafana links to show the Prometheus metrics collected during the job's run.
Checks