Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless #48

Merged
merged 2 commits into from
Sep 28, 2024
Merged

chore: remove useless #48

merged 2 commits into from
Sep 28, 2024

Conversation

ajuner
Copy link
Contributor

@ajuner ajuner commented May 27, 2022

Summary by CodeRabbit

  • 新特性
    • 移除了Segmented组件中onChange事件处理程序的disabled状态检查,允许在禁用状态下仍能执行相关操作。

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (84ce28b) to head (e063855).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   98.44%   99.21%   +0.76%     
==========================================
  Files           2        2              
  Lines         129      127       -2     
  Branches       30       29       -1     
==========================================
- Hits          127      126       -1     
+ Misses          2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Aug 5, 2024

为啥删掉这个?

@ajuner
Copy link
Contributor Author

ajuner commented Aug 5, 2024

为啥删掉这个?

有点久忘了。。。现在看起来这块逻辑跟InternalSegmentedOption内部的change事件有重复,实际上是多余的,会导致单测覆盖不到这块逻辑

@afc163 afc163 requested a review from vagusX August 5, 2024 16:02
@afc163
Copy link
Member

afc163 commented Aug 5, 2024

@vagusX 看看这个

Copy link

coderabbitai bot commented Sep 28, 2024

Walkthrough

此次更改涉及移除Segmented组件onChange事件处理程序中的disabled状态条件检查。之前,当disabled标志为真时,函数会提前返回,防止进一步操作。修改后,该检查被删除,使得setRawValue(val)onChange?.(val)调用在disabled状态下也能执行。

Changes

文件 更改摘要
src/index.tsx 移除Segmented组件onChange事件处理程序中的disabled状态检查。

Poem

在草地上,兔子跳跃欢,
移除条件,变化如风般。
无论状态,依旧前行,
代码流畅,乐声悠扬。
小小改动,喜悦无边! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 84ce28b and e063855.

📒 Files selected for processing (1)
  • src/index.tsx (0 hunks)
💤 Files not reviewed due to no reviewable changes (1)
  • src/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@afc163 afc163 merged commit 156d461 into react-component:master Sep 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants