Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when using scrollTo the outer layer also scrolls at the same time #1064

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fatpandac
Copy link

使用 scrollTo 替换 scrollIntoView,避免出现嵌套滚动 div 的时候,使内部 div 滚动同时导致外部的 div 也一起滚动。

ant-design/ant-design#46467

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 1:41pm

@afc163
Copy link
Member

afc163 commented Dec 27, 2023

ci failed

@Fatpandac
Copy link
Author

These two tests failed because I deprecated the scrollIntoView().
Can I remove these tests?

@afc163
Copy link
Member

afc163 commented Dec 27, 2023

Yes if these test cases is useless.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b72776c) 99.51% compared to head (c93290a) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1064   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          47       47           
  Lines        4518     4527    +9     
  Branches      571      572    +1     
=======================================
+ Hits         4496     4505    +9     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Dec 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants