Skip to content

Commit

Permalink
Make the ad CTA a button (#401)
Browse files Browse the repository at this point in the history
Note: this only applies to the sidebar or (non fixed) footer ad. My idea
here was to test it out and see how this performs before rolling it out
on the EA styled ads. Any feedback before rolling it out is also
valuable.

## Screenshot
![Screenshot from 2024-10-10
15-36-51](https://github.com/user-attachments/assets/10ae752a-b839-4341-892f-688961122675)
  • Loading branch information
davidfischer authored Oct 12, 2024
1 parent c958fa8 commit 26b1078
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
4 changes: 2 additions & 2 deletions dist/readthedocs-addons.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions src/ethicalads.css
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ div.ethical-footer {
border: 0;
}

.ethical-sidebar .ea-cta,
.ethical-footer .ea-cta {
display: block;
border: 1px solid #ccc;
border-radius: 0.5em;
margin-top: 0.5em;
margin-left: 1em;
margin-right: 1em;
}

.ethical-sidebar,
.ethical-footer {
background-color: #eee;
Expand Down Expand Up @@ -222,6 +232,10 @@ div.ethical-footer {
.ethical-dark-theme .ethical-callout a {
color: #b3b3b3 !important;
}
.ethical-dark-theme .ethical-sidebar .ea-cta,
.ethical-dark-theme .ethical-footer .ea-cta {
border-color: #a0a0a0;
}

/* Docusaurus */
.ethical-docusaurus {
Expand Down

0 comments on commit 26b1078

Please sign in to comment.