Fix the filters title covering other labels #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
approved these changes
Aug 2, 2024
|
In my tests, the checkbox is still covered by the "Filters" border/padding or similar in Chrome. I'm having the same behavior reported in the issue. @zanderle can you share a screenshot on how it behaves for you? |
|
@zanderle were you able to take a look at this? |
zanderle
force-pushed
the
zanderle/fix-search-filters-styling
branch
from
5c3dbec
to
59fee41
Compare
|
Should be ok now. Sorry for the delay.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293
There's still a slight difference. The only way to avoid that completely, would be to remove the default checkbox, and style our own. But I'm not really keen on that solution.
BTW this styling/positioning will probably be further improved in #292 , so this is just a quick solution to make it look better.