Merge pull request #938 from readthedocs/davidfischer/fix-task-import

Fix a celerybeat task configuration
readthedocs · Nov 4, 2024 · 795a0bf · 795a0bf
2 parents c84adf3 + 76ebdf7
commit 795a0bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/config/settings/base.py b/config/settings/base.py
@@ -40,9 +40,9 @@
 
     import ethicalads_ext  # noqa
 
-    ext = True
+    ADSERVER_EXT = True
 except ImportError:
-    ext = False
+    ADSERVER_EXT = False
 
 # Quick-start development settings - unsuitable for production
 # See https://docs.djangoproject.com/en/4.2/howto/deployment/checklist/
@@ -533,9 +533,9 @@
 )
 if ADSERVER_ANALYZER_BACKEND:
     INSTALLED_APPS.append("adserver.analyzer")
-if ADSERVER_ANALYZER_BACKEND and ext:
+if ADSERVER_ANALYZER_BACKEND and ADSERVER_EXT:
     INSTALLED_APPS.append("ethicalads_ext.embedding")
-if ext:
+if ADSERVER_EXT:
     INSTALLED_APPS.append("ethicalads_ext.support")
 
 # Whether Do Not Track is enabled for the ad server

diff --git a/config/settings/production.py b/config/settings/production.py
@@ -195,8 +195,9 @@
         "task": "adserver.analyzer.tasks.daily_analyze_urls",
         "schedule": crontab(hour="4", minute="0"),
     }
+if "ethicalads_ext.embedding" in INSTALLED_APPS:
     CELERY_BEAT_SCHEDULE["every-day-analyze-advertiser-urls"] = {
-        "task": "adserver.analyzer.tasks.daily_analyze_advertiser_urls",
+        "task": "ethicalads_ext.embedding.tasks.daily_analyze_advertiser_urls",
         "schedule": crontab(hour="4", minute="30"),
     }