docs(readme): rewrite #846
Conversation
Co-authored-by: Michael Kriese <[email protected]>
| @@ -353,9 +352,9 @@ For example: | |||
|
|
|||
| ## Environment Variables | |||
|
|
|||
| If you wish to pass through environment variables through to the Docker container that powers this action you need to prefix the environment variable with `RENOVATE_`. | |||
| To pass through environment variables through to the Docker container that powers this action, you must prefix the environment variable with `RENOVATE_`. | |||
There was a problem hiding this comment.
we should remove this must prefix, it's totally wrong and we should not suggest that.
There was a problem hiding this comment.
| To pass through environment variables through to the Docker container that powers this action, you must prefix the environment variable with `RENOVATE_`. | |
| If you wish to pass environment variables to the Docker container that powers this action, prefix the environment variable with `RENOVATE_`. |
Is this what you want?
There was a problem hiding this comment.
no, remove the prefix suggestion completely. I know it's going worse for now but I don't like to suggest a totally wrong configuration.
we can leave the sample for now, or maybe better also remove it. I'll probably doing some changes when I'm back at work.
There was a problem hiding this comment.
I'll let you push the changes to my branch then! 😉
There was a problem hiding this comment.
then it has to wait until next week. ⛱️🍹
This comment was marked as resolved.
This comment was marked as resolved.
|
@viceice I resolved the merge conflict, I'll let you push the changes you want to my branch. 😉 |
| # Unfortunately, the permissions expected within Renovate's Docker container | ||
| # are different than the ones given after the cache is restored. We must | ||
| # change ownership to solve this. We also must have the correct permissions in | ||
| # the entire /tmp/renovate tree, not just the section with the repo cache. | ||
| sudo chown -R runneradmin:root /tmp/renovate/ | ||
| ls -R $cache_dir |
There was a problem hiding this comment.
This seems to no longer work. On the other hand, there is now a docker-user option.
I am now using the following:
- name: Determine current user
id: id
run: |
echo "user=$(id -u)" >> $GITHUB_OUTPUT
echo "group=$(id -g)" >> $GITHUB_OUTPUT
- uses: renovatebot/[email protected]
with:
configurationFile: renovate.json5
token: ${{ secrets.RENOVATE_TOKEN }}
renovate-version: 37.421.3
# used to mount cache
docker-user: "${{ steps.id.outputs.user }}:${{ steps.id.outputs.group }}"
docker-volumes: |
/tmp/renovate/cache:/tmp/renovate/cache
env:
# This enables the cache -- if this is set, it's not necessary to add it to renovate.json.
RENOVATE_REPOSITORY_CACHE: ${{ github.event.inputs.repoCache || 'enabled' }}
Changes:
Context:
Adds info I asked about in:
Please review thoroughly for technical correctness!