Validate configuration #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-isler
commented
Nov 12, 2024
| def model(name) | ||
| model_config = ModelConfig.new(name).tap do |config| | ||
| yield(config) | ||
| Rails.application.config.to_prepare { config.validate! } |
There was a problem hiding this comment.
the models are not loaded here yet. so model.column_names would raise for example. that's why I'm scheduling them for Rails to pick them up as soon as you init the server or so
example if an invalid attribute is specified and you boot up Rails:
Exiting
/Users/simon/r/hotsheet/lib/hotsheet/configuration.rb:49:in `block in validate_attribute_existence': Attribute 'test' doesn't exist on model 'Post' (RuntimeError)
from /Users/simon/r/hotsheet/lib/hotsheet/configuration.rb:47:in `each'
from /Users/simon/r/hotsheet/lib/hotsheet/configuration.rb:47:in `validate_attribute_existence'
from /Users/simon/r/hotsheet/lib/hotsheet/configuration.rb:32:in `validate!'
from /Users/simon/r/hotsheet/lib/hotsheet/configuration.rb:16:in `block (2 levels) in model'
simon-isler
force-pushed
the
feature/validate-config
branch
from
32c1029
to
30dc01e
Compare
|
|
simon-isler
force-pushed
the
feature/validate-config
branch
from
9a35963
to
e7bc0af
Compare
simon-isler
commented
Nov 12, 2024
| end | ||
|
|
||
| def validate! | ||
| return unless ActiveRecord::Base.connection.table_exists?(model_class.table_name) |
There was a problem hiding this comment.
we currently only support ActiveRecord models (due to .column_names) calls mainly. so this should be fine
ignaciosy
approved these changes
Nov 14, 2024
simon-isler
force-pushed
the
feature/validate-config
branch
from
e7bc0af
to
670f80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.