Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version release is broken :( #123

Closed
notmgsk opened this issue Nov 7, 2022 · 5 comments · May be fixed by #135
Closed

New version release is broken :( #123

notmgsk opened this issue Nov 7, 2022 · 5 comments · May be fixed by #135
Labels
CI/CD

Comments

@notmgsk
Copy link
Contributor

notmgsk commented Nov 7, 2022

The latest quil-rs version on crates.io is v0.14.1. The version specified in Cargo.toml is 0.10.0, which happened in a recent merge which should have bumped the version to 0.15.0.

Not really sure how it got into this pickle, but it's something we should fix before it gets us into trouble.

Changing Cargo.toml's version to 0.14.1 and running knope --dry-run prerelease shows the version would be bumped to 0.11.0, so that's not the issue...

(Paging the wise and wonderful @dbanty just in case they can spare a few minutes for their old friends.)
@notmgsk notmgsk added the CI/CD label Nov 7, 2022
@kalzoo
Copy link
Contributor

kalzoo commented Nov 15, 2022

Would we not expect pushing an updated Cargo.toml and tag onto main to fix this?

@notmgsk notmgsk mentioned this issue Nov 16, 2022
Closed
@notmgsk
Copy link
Contributor Author

notmgsk commented Nov 16, 2022

Would we not expect pushing an updated Cargo.toml and tag onto main to fix this?

Tried it locally without success.

@Shadow53
Copy link
Contributor

Shadow53 commented Nov 16, 2022 •
edited
Loading

This PR has the fix for knope: knope-dev/knope#323

As part of resolving this issue, though, we should make sure the release rule actually calls the Release action -- it does not currently (prerelease has one more step than release does).

Same with cargo update -w

@dbanty
Copy link
Contributor

dbanty commented Nov 17, 2022

As part of resolving this issue, though, we should make sure the release rule actually calls the Release action -- it does not currently (prerelease has one more step than release does).

You may be able to switch to --prerelease-label now to unify those rules.

Sorry I didn't get your summons @notmgsk, not sure why a mention didn't land in my notifications 🤔. Thanks for contributing a fix though, folks. I'll have that new version out soon.

Miss you 💜

@Shadow53 Shadow53 mentioned this issue Nov 17, 2022
Open
This was referenced Feb 6, 2023
Closed
Closed
@MarquessV
Copy link
Contributor

Fixed in #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix release workflow rigetti/quil-rs
5 participants
@MarquessV @Shadow53 @notmgsk @kalzoo @dbanty