Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow #135

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ci: fix release workflow #135

wants to merge 4 commits into from

Conversation

Shadow53
Copy link
Contributor

Resolves #123.

  • Updates the knope version
  • Per @dbanty, --prerelease-label calls a workflow but as a prerelease. So to deduplicate the knope.toml (and avoid issues like with missing the Release step), the file now contains only a release workflow, and the CI calls it with --prerelease-label for prereleases.
    • One potential argument against this is that the prerelease commit message now says "release" instead of "prerelease". Since it includes the release tag, including a rc.x part, I think that conveys "prerelease" appropriately.
    • That said, I am open to arguments for restoring a "prerelease" workflow.

@notmgsk
Copy link
Contributor

notmgsk commented Nov 18, 2022

We're probably going to have a problem when we get to 0.15.0, since there is already a 0.15.0-rc.0 on crates.io. Do you think we should just tag 0.15.1 and go from there?

@Shadow53
Copy link
Contributor Author

We're probably going to have a problem when we get to 0.15.0, since there is already a 0.15.0-rc.0 on crates.io. Do you think we should just tag 0.15.1 and go from there?

I am hoping that, once we reach that point, knope will detect the prerelease and automatically skip it.

If I read this function correctly, it will ignore the latest prerelease if the major/minor/patch versions do not match the current stable.

... Which made me wonder if we'll run into an issue where we keep hitting 0.14.3-rc.0. It looks like yes, so we might need a new PR to knope :/

@Shadow53
Copy link
Contributor Author

Shadow53 commented Feb 6, 2023

Updated the knope version to 0.7.0 and fixed some clippy lints so that CI passes.

@BatmanAoD
Copy link
Contributor

@Shadow53 Is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version release is broken :(
4 participants