Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions containing NaN are not equal when everything else matches #316

Open
Shadow53 opened this issue Nov 23, 2023 · 0 comments · May be fixed by #318
Open

Expressions containing NaN are not equal when everything else matches #316

Shadow53 opened this issue Nov 23, 2023 · 0 comments · May be fixed by #318

Comments

@Shadow53
Copy link
Contributor

This was surfaced by proptest fuzzing just now. The expression "aa[0]/(pi - pi)" fails the simplification test because NaN != NaN. This follows the IEEE standard, but I think for our purposes it may make sense to make them equal for the purposes of PartialEq for Expression.
Shadow53 added a commit that referenced this issue Nov 23, 2023
@Shadow53
fix: make NaN == NaN inside Expression
39f4714 
This is the easiest way to resolve #316 in a way that doesn't break the
API (the other way being to use `OrderedFloat`).
@Shadow53 Shadow53 linked a pull request Nov 23, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make NaN == NaN inside Expression rigetti/quil-rs
1 participant
@Shadow53