Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make NaN == NaN inside Expression #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make NaN == NaN inside Expression #318

wants to merge 1 commit into from

Conversation

Shadow53
Copy link
Contributor

This is the easiest way to resolve #316 in a way that doesn't break the API (the other way being to use OrderedFloat).

Fixes #316.

@Shadow53
fix: make NaN == NaN inside Expression
39f4714 
This is the easiest way to resolve #316 in a way that doesn't break the
API (the other way being to use `OrderedFloat`).
BatmanAoD
BatmanAoD reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@BatmanAoD BatmanAoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me; I don't think I'm the one to make the call on actually deciding we want NaN==NaN for our users, though.

@notmgsk
Copy link
Contributor

notmgsk commented Dec 14, 2023 •
edited
Loading

Hm. Not sure how to feel about this one. Part of me wants something like Expression::Nan, or Expression::Invalid(DivisionByZero)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatmanAoD BatmanAoD BatmanAoD left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expressions containing NaN are not equal when everything else matches
3 participants
@Shadow53 @notmgsk @BatmanAoD