fix: return response for non json (#5785)

* fix: return response for non json * chore: format * fix: check for proper header * Return content type from fetch mocks --------- Co-authored-by: Aditya Hegde <[email protected]>
rilldata · Sep 26, 2024 · 0a38393 · 0a38393 · github-actions · Sep 26, 2024
1 parent 30841ab
commit 0a38393
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/web-common/src/features/dashboards/dashboard-fetch-mocks.ts b/web-common/src/features/dashboards/dashboard-fetch-mocks.ts
@@ -88,6 +88,7 @@ export class DashboardFetchMocks {
       ready: true,
       ok: true,
       json: () => this.responses.get(key),
+      headers: new Map([["content-type", "application/json"]]),
     };
   }
 }
diff --git a/web-common/src/runtime-client/fetchWrapper.ts b/web-common/src/runtime-client/fetchWrapper.ts
@@ -49,6 +49,10 @@ export async function fetchWrapper({
     signal,
   });
 
+  const contentType = resp.headers?.get("content-type");
+  if (!contentType?.includes("application/json") && resp.ok) {
+    return resp;
+  }
   const json = await resp.json();
 
   if (resp.ok) return json;