removing unique index (#2705)

* removing unique index

* ut fix

* adding comments

runtime/drivers/catalog_test.go

@@ -52,7 +52,7 @@ func testCatalog(t *testing.T, catalog drivers.CatalogStore) {
 
 	err = catalog.CreateEntry(ctx, instanceID, obj1)
 	require.Error(t, err)
-	require.True(t, strings.Contains(err.Error(), "duplicate key") ||
+	require.True(t, strings.Contains(err.Error(), "already exists") ||
 		strings.Contains(err.Error(), "Duplicate key") ||
 		strings.Contains(err.Error(), "UNIQUE constraint failed"))
 

runtime/drivers/duckdb/catalog.go

@@ -88,6 +88,17 @@ func (c *connection) CreateEntry(ctx context.Context, instanceID string, e *driv
 	}
 	defer func() { _ = release() }()
 
+	var present bool
+	if err := conn.QueryRowContext(ctx, "SELECT COUNT(*) > 0 AS present FROM rill.catalog WHERE name = ?", e.Name).Scan(&present); err != nil {
+		return err
+	}
+
+	// adding a application side check instead of unique index bcz of duckdb limitations on indexes
+	// https://duckdb.org/docs/sql/indexes#over-eager-unique-constraint-checking
+	if present {
+		return fmt.Errorf("catalog entry with name %q already exists", e.Name)
+	}
+
 	// Serialize object
 	obj, err := proto.Marshal(e.Object)
 	if err != nil {

runtime/drivers/duckdb/migrations/0005.sql

@@ -0,0 +1 @@
+DROP INDEX IF EXISTS rill.lower_name_unique_idx;

runtime/registry_test.go

@@ -214,6 +214,13 @@ func TestRuntime_DeleteInstance(t *testing.T) {
 					Managed: true,
 				},
 			}))
+			require.ErrorContains(t, svc.Catalog.CreateEntry(ctx, "default", &drivers.CatalogEntry{
+				Name: "data",
+				Type: drivers.ObjectTypeModel,
+				Object: &runtimev1.Model{
+					Name: "data",
+				},
+			}), "catalog entry with name \"data\" already exists")
 
 			// delete instance
 			err = rt.DeleteInstance(ctx, tt.instanceID, tt.dropDB)