Deprecate app store in favor of derived store #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
requested changes
Jul 3, 2023
web-common/src/features/models/workspace/inspector/EmbeddedSourceReference.svelte
Outdated
Show resolved
Hide resolved
AdityaHegde
reviewed
Jul 4, 2023
| activeEntity: undefined, | ||
| previousActiveEntity: undefined, | ||
| } as AppStore); | ||
|
|
||
| const appStoreReducers = { | ||
| setActiveEntity(name: string, type: EntityType) { | ||
| update((state) => { | ||
| state.previousActiveEntity = state.activeEntity; |
There was a problem hiding this comment.
Why is this moved to the top? Wouldnt this make the current entity inactive? Either move this to the bottom or move the call to setActiveEntity to the top in appScreen body.
There was a problem hiding this comment.
The previous implementation had a bug. Corrected it with these changes. You can verify by console logging state.previousActiveEntity.name when it's being made inactive.
Now when you move from asset A to asset B, asset A is being made inactive now.
name provided through props is the current active entity being set. state.activeEntity just before being updated is now the previous active entity which has to be made inactive.
AdityaHegde
approved these changes
Jul 4, 2023
cohenscottr
added a commit
that referenced
this pull request
Jul 13, 2023
commit 0e69153 Author: Eric P Green <[email protected]> Date: Wed Jul 12 14:57:22 2023 -0400 Handle "repository not found" error (#2769) commit df483d7 Author: Speros Kokenes <[email protected]> Date: Wed Jul 12 09:21:54 2023 -0500 fix: Filters bar not rendering search results properly (#2759) * fix: item rendering, flashing * comment * fix: search bug; tests * feat: move activeColumn def commit b6f4ee3 Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:44:00 2023 +0530 DuckDB sql parser (#2745) * Basic AST traversal * Adding basic table rewrite * Adding basic limit rewrite * Use native json and support CTE and Unions * Adding basic column extraction * Adding basic annotion parser * Sources sql prototype * Adding column expression parsing * Addressing PR comments * Revert prototype code commit be5ce9f Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:02:05 2023 +0530 Adding batching API (#2716) * Adding batching API * Adding tests and PR comments * Addressing PR comments commit 6c27aac Author: Speros Kokenes <[email protected]> Date: Tue Jul 11 14:31:14 2023 -0500 feat: app business model context (#2704) * feat: init context sharing * example * fix: lint issue * cleanup * feat: rename business model to state managers commit 5565678 Author: Hamilton Ulmer <[email protected]> Date: Tue Jul 11 12:20:59 2023 -0700 removes render condition from totalsQuery (#2766) commit 0cc1c72 Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 16:45:59 2023 +0200 Enforce export limits only on cloud (#2762) * Enforce export limits only on cloud * Revert MetricsViewRows limit to int32 * Regenerate Orval * Fix missing underscore in filename * Nit commit e3d57b1 Author: bcolloran <[email protected]> Date: Tue Jul 11 07:38:31 2023 -0700 add command to smoketest storybook (#2671) commit 16ad755 Author: Anshul Khandelwal <[email protected]> Date: Tue Jul 11 15:05:45 2023 +0530 motherduck docs (#2752) * motherduck docs * motherduck docs commit 1cf7dec Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 11:32:31 2023 +0200 Runtime: Add available_time_zones to dashboard YAML (#2764) commit cb09fb2 Author: Hamilton Ulmer <[email protected]> Date: Mon Jul 10 10:50:44 2023 -0700 YAML editor; integration into `/dashboard/<name>/edit` (#2639) * work out placeholder text * update placeholder to enable auto-generating * adds in skeleton and bootstrap functions to placeholder * renames components * fix overflow issues in new metrics editor * remove all error state when buffer is empty * move editor plugins around * update Placeholder.svelte * adds link to documentation in metrics inspector * move doc link * self-review * update package.json to move to devDependencies * spacing on docs link * center align doc link * remove unused var * remove doc link from inspector * minor refactors to code org for extensions * adds slight debounce to state update function for line levels * move to queryClient.fetchQuery in placeholder model bootstrap * update component structure; move status updates to MetricsWorkspace.svelte * moves basic extensions to base.ts * adds a way to annotate an editor buffer update so we can either add or remove debouncing updates * establishes line number gutter marker, and breaks out the gutters for the line statuses into two distinct entities * fix debounce situation when document is empty * block button nav to dashboard if invalid config * adds create-debouncer.ts, which is a simpler debouncer that operates on the end of a debounced sequence, not the beginning * add story for generic YAML editor, including option for adding line errors * rename files; change Portal implementation since we presume this is all browser-only, which helps with Storybook * adds line number gutter test * add line status gutter tests * adds line status highlighter tests * adds basic tests for indent-guide extension * fix lint error in GoToDashboardButton.svelte * remove unused metrics editor files; fix types * remove unneeded logic from EditorContainer.svelte * shifts around logic to be per-surface * refine reconciliation debouncing * add basic model summary info to metrics inspector based on feedback * fix line level error coloring * adapts e2e tests and adds a new empty metrics flow * switches debounce annotation to be a boolean * fix minor prettier errors * revert useTestServer.ts * fix line-number-gutter.spec.ts * fix YAMLEditor.spec.ts * refine placeholder code * streamlines and fixes codemirror dependencies; removes old codemirror package code from web-local * moves to metrics editor container; re-instates other dashboard tests that were skipped before * fix lint error * moves metrics def errors function to file-artifacts-store.ts and makes it generic for any file type * rename function for file artifact reconciliation errors * move errors to common place for metrics-view * remove unneeded flex which was causing metrics editor to mount halfway down * fix story lint errors * re-adds storybook editor view * fix line selection color compositing * address feedback comments * removes mismatch between line errors and reconciled yaml file * remove console..og commit 5ffc41d Author: Marissa Gorlick <[email protected]> Date: Sun Jul 9 14:30:25 2023 -0500 release notes 0.29 (#2756) Co-authored-by: Marissa Gorlick <[email protected]> commit 7a454b1 Author: Aditya Hegde <[email protected]> Date: Sun Jul 9 18:58:54 2023 +0530 Fix 1st time state being overriden (#2755) commit 54320f7 Author: Anshul Khandelwal <[email protected]> Date: Fri Jul 7 13:56:48 2023 +0530 Motherduck connector preflight APIs (#2746) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set * motherduck preflight apis * md preflight api --------- Co-authored-by: Aditya Hegde <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 31688e2 Author: Rakesh Sharma <[email protected]> Date: Fri Jul 7 13:29:56 2023 +0530 Implement deployment hibernation (#2363) * initial commit * added func to check for expired deployments and de-provision them * fmt * go mod tidy * review changes * hibernation deployment job * small changes * TriggerReprovision added * fix unused opts in admin.go * Add status chip for `HIBERNATED` state * review changes * merging issue * hibernation job time * nit * review changes * reverted ui changes for hibernation * nit * review changes * added sync.WaitGroup for flusher * Review * Run prettier * Review part 2 * Move logic to a custom hook * Add redirect for all routes under `/org/project` --------- Co-authored-by: Eric P Green <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 2bca601 Author: Aditya Hegde <[email protected]> Date: Fri Jul 7 13:23:17 2023 +0530 Use trylock for populating parents/children in catalog queries (#2747) commit 3d105ab Author: Anshul Khandelwal <[email protected]> Date: Thu Jul 6 23:24:36 2023 +0530 Motherduck connector (#2739) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set --------- Co-authored-by: Aditya Hegde <[email protected]> commit 7d27a4d Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 19:46:54 2023 +0200 Remove measures length validation from toplist APIs (#2748) commit 41fa1fc Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 18:33:43 2023 +0200 Add dashboard YAML property for percent of total (#2590) * Add dashboard YAML property for percent of total * Change to valid_percent_of_total commit df0b53f Author: Speros Kokenes <[email protected]> Date: Thu Jul 6 03:47:32 2023 -0400 wait for process to end (#2550) commit 41b52e4 Author: bcolloran <[email protected]> Date: Wed Jul 5 11:11:04 2023 -0700 button group Component (#2625) * adding stories for buttons, and adding mock svelteKit $app/environment in storybook * cleanup * create ButtonToggleGroup.svelte (empty) * fix package-lock.json * rebuilding package-lock.json again * try package-lock again * try updating vite.config.ts to fix build * revert package-lock to match main * remove fixme comment * start button group stories * initial work on button groups * Button group implemented and stories for button group provided * cleanup and doc * Fix defaultselection handling and improve stories * add tooltips, update stories * update doc * cleanup and rename * fix divider * fix prettier * another prettier fix * another prettier fix * yet another prettier fix * Even more prettier fixes * rework buttonToggleGroup component to be fully controlled * rename component as "ButtonGroup" since it doesn't handle its own toggle state * rename stories file * update story table padding * TS+lint+prettier cleanups * update "test:watch", vitest runs in watch mode by default * update vite config to mock $app/environment for testing * adding first set of tests * add tests * lint fix * update readme commit 480ead7 Author: Rakesh Sharma <[email protected]> Date: Wed Jul 5 19:06:30 2023 +0530 Implement DB size estimation for DuckDB (#2742) * added EstimateSize in OLAPStore * review changes commit 00130c2 Author: Benjamin Egelund-Müller <[email protected]> Date: Wed Jul 5 15:23:50 2023 +0200 Scaffolding of DuckDB SQL utils needed for async reconcile (#2731) commit d41c928 Author: Egor Riashin <[email protected]> Date: Wed Jul 5 10:48:30 2023 +0300 Arbitrary SQL (#2702) * arbitrary SQL * proto * custom-query * custom-query * custom-query * custom-query * custom query tests * custom query * custom query * custom query * custom query * arbitrary-sql * custom query * custom query * proto * non-recursive --------- Co-authored-by: egor-ryashin <[email protected]> commit 1453d9b Author: Eric P Green <[email protected]> Date: Tue Jul 4 15:06:35 2023 -0400 Remove embedded sources from Source UI (#2738) * Remove embedded sources from Source Catalog UI * Colocate embedded source code * Fix `svelte-check` * Remove link * Remove tooltip commit 31149b8 Author: Rakesh Sharma <[email protected]> Date: Tue Jul 4 18:50:41 2023 +0530 Check if provided sources exists for reconcile refresh sources (#2741) * check if provided sources exists for reconcile refresh sources * review changes commit 744f6c7 Author: Dhiraj Barnwal <[email protected]> Date: Tue Jul 4 17:22:41 2023 +0530 Deprecate app store in favor of derived store (#2710) * Remove usage of appStore * Add missing navigation event * Fix types * Add comment * Add cloud dashboard route to telemetry * Use a tag for link * Remove comment commit 0746566 Author: Rohith Reddy Kota <[email protected]> Date: Tue Jul 4 17:11:35 2023 +0530 docs: update import-data (#2721) * docs: update import-data * docs: update import-data commit 4d4c5e0 Author: Aditya Hegde <[email protected]> Date: Tue Jul 4 17:08:55 2023 +0530 Updating timeseries API to new validations (#2740) commit 4a9b8e5 Author: Eugene Sevastianov <[email protected]> Date: Mon Jul 3 19:38:19 2023 +0400 Rate limiting (per operation, per auth/ip) (#2640) * 2347: Admin/Runtime: Rate limiting (per operation, per auth/ip) * Provided descriptions for key structs * Refactored according to PR comments * Limiter interface * Fixed formatting * Fixed tests * Updated func declarations according the lint * Changed LimiterHTTPHandler visibility * Made limit checks more explicit by materializing them in respective packages * Added a request to Metadata so that it is available in a handler * Fixed linter errors * Fixed linter errors * added zap.Error(err) * Reverted auto-IDE change * Added a comment * Simplified by using grpc_auth.UnaryServerInterceptor * Tripled rate limits before we have real numbers measured by a usage tracking * Reverted auto change * check if claims == nil --------- Co-authored-by: e.sevastyanov <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 3e8090a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 20:28:24 2023 +0530 Search and get project support for support users (#2691) * search and get project support for superusers * review changes * review changes * pr changes * Update admin/server/projects.go * Update admin/server/projects.go --------- Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 48ae852 Author: Benjamin Egelund-Müller <[email protected]> Date: Mon Jul 3 16:32:47 2023 +0200 CLI: Print suggestions when trying to deploy an existing project (#2689) * CLI: Print suggestions when trying to deploy an existing project * Address review comment commit 507bf57 Author: Speros Kokenes <[email protected]> Date: Mon Jul 3 10:18:36 2023 -0400 feat: export button on dashboard (#2667) * feat: export button on dashboard * feat: move button to drawer lid * fix: lint errors * feat: e2e test, date picker fix * fix: lint issues commit 5d2691a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:19:37 2023 +0530 2649 cli implement whoami command (#2674) * 2649-cli-implement-whoami-command * added whoami cmd * review changes * nit changes commit eea5652 Author: Egor Riashin <[email protected]> Date: Mon Jul 3 16:48:01 2023 +0300 Additional queries validation (#2712) * queries validation * queries validation * queries validation * queries validation * proto.validate --------- Co-authored-by: Egor Ryashin <[email protected]> commit 9a6a2f4 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:16:56 2023 +0530 Admin: email invite redirect to signup (#2720) * admin redirect to signup * nit * review changes commit 4c7b069 Author: Dhiraj Barnwal <[email protected]> Date: Mon Jul 3 19:05:25 2023 +0530 Show sign up auth page when suggested (#2722) commit 6154524 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:04:27 2023 +0530 Auto fix removed for linters (#2727) * linter fail * revert * auto fix removed for linters commit a947888 Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:35:25 2023 +0530 Using the correct field to show toplist delta (#2725) * Using the correct field to show toplist delta * Fixing tests commit 3edadcf Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:31:34 2023 +0530 Call goto once for the same state (#2723)
ericpgreen2
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Squashed commit of the following: commit 0e69153 Author: Eric P Green <[email protected]> Date: Wed Jul 12 14:57:22 2023 -0400 Handle "repository not found" error (#2769) commit df483d7 Author: Speros Kokenes <[email protected]> Date: Wed Jul 12 09:21:54 2023 -0500 fix: Filters bar not rendering search results properly (#2759) * fix: item rendering, flashing * comment * fix: search bug; tests * feat: move activeColumn def commit b6f4ee3 Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:44:00 2023 +0530 DuckDB sql parser (#2745) * Basic AST traversal * Adding basic table rewrite * Adding basic limit rewrite * Use native json and support CTE and Unions * Adding basic column extraction * Adding basic annotion parser * Sources sql prototype * Adding column expression parsing * Addressing PR comments * Revert prototype code commit be5ce9f Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:02:05 2023 +0530 Adding batching API (#2716) * Adding batching API * Adding tests and PR comments * Addressing PR comments commit 6c27aac Author: Speros Kokenes <[email protected]> Date: Tue Jul 11 14:31:14 2023 -0500 feat: app business model context (#2704) * feat: init context sharing * example * fix: lint issue * cleanup * feat: rename business model to state managers commit 5565678 Author: Hamilton Ulmer <[email protected]> Date: Tue Jul 11 12:20:59 2023 -0700 removes render condition from totalsQuery (#2766) commit 0cc1c72 Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 16:45:59 2023 +0200 Enforce export limits only on cloud (#2762) * Enforce export limits only on cloud * Revert MetricsViewRows limit to int32 * Regenerate Orval * Fix missing underscore in filename * Nit commit e3d57b1 Author: bcolloran <[email protected]> Date: Tue Jul 11 07:38:31 2023 -0700 add command to smoketest storybook (#2671) commit 16ad755 Author: Anshul Khandelwal <[email protected]> Date: Tue Jul 11 15:05:45 2023 +0530 motherduck docs (#2752) * motherduck docs * motherduck docs commit 1cf7dec Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 11:32:31 2023 +0200 Runtime: Add available_time_zones to dashboard YAML (#2764) commit cb09fb2 Author: Hamilton Ulmer <[email protected]> Date: Mon Jul 10 10:50:44 2023 -0700 YAML editor; integration into `/dashboard/<name>/edit` (#2639) * work out placeholder text * update placeholder to enable auto-generating * adds in skeleton and bootstrap functions to placeholder * renames components * fix overflow issues in new metrics editor * remove all error state when buffer is empty * move editor plugins around * update Placeholder.svelte * adds link to documentation in metrics inspector * move doc link * self-review * update package.json to move to devDependencies * spacing on docs link * center align doc link * remove unused var * remove doc link from inspector * minor refactors to code org for extensions * adds slight debounce to state update function for line levels * move to queryClient.fetchQuery in placeholder model bootstrap * update component structure; move status updates to MetricsWorkspace.svelte * moves basic extensions to base.ts * adds a way to annotate an editor buffer update so we can either add or remove debouncing updates * establishes line number gutter marker, and breaks out the gutters for the line statuses into two distinct entities * fix debounce situation when document is empty * block button nav to dashboard if invalid config * adds create-debouncer.ts, which is a simpler debouncer that operates on the end of a debounced sequence, not the beginning * add story for generic YAML editor, including option for adding line errors * rename files; change Portal implementation since we presume this is all browser-only, which helps with Storybook * adds line number gutter test * add line status gutter tests * adds line status highlighter tests * adds basic tests for indent-guide extension * fix lint error in GoToDashboardButton.svelte * remove unused metrics editor files; fix types * remove unneeded logic from EditorContainer.svelte * shifts around logic to be per-surface * refine reconciliation debouncing * add basic model summary info to metrics inspector based on feedback * fix line level error coloring * adapts e2e tests and adds a new empty metrics flow * switches debounce annotation to be a boolean * fix minor prettier errors * revert useTestServer.ts * fix line-number-gutter.spec.ts * fix YAMLEditor.spec.ts * refine placeholder code * streamlines and fixes codemirror dependencies; removes old codemirror package code from web-local * moves to metrics editor container; re-instates other dashboard tests that were skipped before * fix lint error * moves metrics def errors function to file-artifacts-store.ts and makes it generic for any file type * rename function for file artifact reconciliation errors * move errors to common place for metrics-view * remove unneeded flex which was causing metrics editor to mount halfway down * fix story lint errors * re-adds storybook editor view * fix line selection color compositing * address feedback comments * removes mismatch between line errors and reconciled yaml file * remove console..og commit 5ffc41d Author: Marissa Gorlick <[email protected]> Date: Sun Jul 9 14:30:25 2023 -0500 release notes 0.29 (#2756) Co-authored-by: Marissa Gorlick <[email protected]> commit 7a454b1 Author: Aditya Hegde <[email protected]> Date: Sun Jul 9 18:58:54 2023 +0530 Fix 1st time state being overriden (#2755) commit 54320f7 Author: Anshul Khandelwal <[email protected]> Date: Fri Jul 7 13:56:48 2023 +0530 Motherduck connector preflight APIs (#2746) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set * motherduck preflight apis * md preflight api --------- Co-authored-by: Aditya Hegde <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 31688e2 Author: Rakesh Sharma <[email protected]> Date: Fri Jul 7 13:29:56 2023 +0530 Implement deployment hibernation (#2363) * initial commit * added func to check for expired deployments and de-provision them * fmt * go mod tidy * review changes * hibernation deployment job * small changes * TriggerReprovision added * fix unused opts in admin.go * Add status chip for `HIBERNATED` state * review changes * merging issue * hibernation job time * nit * review changes * reverted ui changes for hibernation * nit * review changes * added sync.WaitGroup for flusher * Review * Run prettier * Review part 2 * Move logic to a custom hook * Add redirect for all routes under `/org/project` --------- Co-authored-by: Eric P Green <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 2bca601 Author: Aditya Hegde <[email protected]> Date: Fri Jul 7 13:23:17 2023 +0530 Use trylock for populating parents/children in catalog queries (#2747) commit 3d105ab Author: Anshul Khandelwal <[email protected]> Date: Thu Jul 6 23:24:36 2023 +0530 Motherduck connector (#2739) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set --------- Co-authored-by: Aditya Hegde <[email protected]> commit 7d27a4d Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 19:46:54 2023 +0200 Remove measures length validation from toplist APIs (#2748) commit 41fa1fc Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 18:33:43 2023 +0200 Add dashboard YAML property for percent of total (#2590) * Add dashboard YAML property for percent of total * Change to valid_percent_of_total commit df0b53f Author: Speros Kokenes <[email protected]> Date: Thu Jul 6 03:47:32 2023 -0400 wait for process to end (#2550) commit 41b52e4 Author: bcolloran <[email protected]> Date: Wed Jul 5 11:11:04 2023 -0700 button group Component (#2625) * adding stories for buttons, and adding mock svelteKit $app/environment in storybook * cleanup * create ButtonToggleGroup.svelte (empty) * fix package-lock.json * rebuilding package-lock.json again * try package-lock again * try updating vite.config.ts to fix build * revert package-lock to match main * remove fixme comment * start button group stories * initial work on button groups * Button group implemented and stories for button group provided * cleanup and doc * Fix defaultselection handling and improve stories * add tooltips, update stories * update doc * cleanup and rename * fix divider * fix prettier * another prettier fix * another prettier fix * yet another prettier fix * Even more prettier fixes * rework buttonToggleGroup component to be fully controlled * rename component as "ButtonGroup" since it doesn't handle its own toggle state * rename stories file * update story table padding * TS+lint+prettier cleanups * update "test:watch", vitest runs in watch mode by default * update vite config to mock $app/environment for testing * adding first set of tests * add tests * lint fix * update readme commit 480ead7 Author: Rakesh Sharma <[email protected]> Date: Wed Jul 5 19:06:30 2023 +0530 Implement DB size estimation for DuckDB (#2742) * added EstimateSize in OLAPStore * review changes commit 00130c2 Author: Benjamin Egelund-Müller <[email protected]> Date: Wed Jul 5 15:23:50 2023 +0200 Scaffolding of DuckDB SQL utils needed for async reconcile (#2731) commit d41c928 Author: Egor Riashin <[email protected]> Date: Wed Jul 5 10:48:30 2023 +0300 Arbitrary SQL (#2702) * arbitrary SQL * proto * custom-query * custom-query * custom-query * custom-query * custom query tests * custom query * custom query * custom query * custom query * arbitrary-sql * custom query * custom query * proto * non-recursive --------- Co-authored-by: egor-ryashin <[email protected]> commit 1453d9b Author: Eric P Green <[email protected]> Date: Tue Jul 4 15:06:35 2023 -0400 Remove embedded sources from Source UI (#2738) * Remove embedded sources from Source Catalog UI * Colocate embedded source code * Fix `svelte-check` * Remove link * Remove tooltip commit 31149b8 Author: Rakesh Sharma <[email protected]> Date: Tue Jul 4 18:50:41 2023 +0530 Check if provided sources exists for reconcile refresh sources (#2741) * check if provided sources exists for reconcile refresh sources * review changes commit 744f6c7 Author: Dhiraj Barnwal <[email protected]> Date: Tue Jul 4 17:22:41 2023 +0530 Deprecate app store in favor of derived store (#2710) * Remove usage of appStore * Add missing navigation event * Fix types * Add comment * Add cloud dashboard route to telemetry * Use a tag for link * Remove comment commit 0746566 Author: Rohith Reddy Kota <[email protected]> Date: Tue Jul 4 17:11:35 2023 +0530 docs: update import-data (#2721) * docs: update import-data * docs: update import-data commit 4d4c5e0 Author: Aditya Hegde <[email protected]> Date: Tue Jul 4 17:08:55 2023 +0530 Updating timeseries API to new validations (#2740) commit 4a9b8e5 Author: Eugene Sevastianov <[email protected]> Date: Mon Jul 3 19:38:19 2023 +0400 Rate limiting (per operation, per auth/ip) (#2640) * 2347: Admin/Runtime: Rate limiting (per operation, per auth/ip) * Provided descriptions for key structs * Refactored according to PR comments * Limiter interface * Fixed formatting * Fixed tests * Updated func declarations according the lint * Changed LimiterHTTPHandler visibility * Made limit checks more explicit by materializing them in respective packages * Added a request to Metadata so that it is available in a handler * Fixed linter errors * Fixed linter errors * added zap.Error(err) * Reverted auto-IDE change * Added a comment * Simplified by using grpc_auth.UnaryServerInterceptor * Tripled rate limits before we have real numbers measured by a usage tracking * Reverted auto change * check if claims == nil --------- Co-authored-by: e.sevastyanov <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 3e8090a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 20:28:24 2023 +0530 Search and get project support for support users (#2691) * search and get project support for superusers * review changes * review changes * pr changes * Update admin/server/projects.go * Update admin/server/projects.go --------- Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 48ae852 Author: Benjamin Egelund-Müller <[email protected]> Date: Mon Jul 3 16:32:47 2023 +0200 CLI: Print suggestions when trying to deploy an existing project (#2689) * CLI: Print suggestions when trying to deploy an existing project * Address review comment commit 507bf57 Author: Speros Kokenes <[email protected]> Date: Mon Jul 3 10:18:36 2023 -0400 feat: export button on dashboard (#2667) * feat: export button on dashboard * feat: move button to drawer lid * fix: lint errors * feat: e2e test, date picker fix * fix: lint issues commit 5d2691a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:19:37 2023 +0530 2649 cli implement whoami command (#2674) * 2649-cli-implement-whoami-command * added whoami cmd * review changes * nit changes commit eea5652 Author: Egor Riashin <[email protected]> Date: Mon Jul 3 16:48:01 2023 +0300 Additional queries validation (#2712) * queries validation * queries validation * queries validation * queries validation * proto.validate --------- Co-authored-by: Egor Ryashin <[email protected]> commit 9a6a2f4 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:16:56 2023 +0530 Admin: email invite redirect to signup (#2720) * admin redirect to signup * nit * review changes commit 4c7b069 Author: Dhiraj Barnwal <[email protected]> Date: Mon Jul 3 19:05:25 2023 +0530 Show sign up auth page when suggested (#2722) commit 6154524 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:04:27 2023 +0530 Auto fix removed for linters (#2727) * linter fail * revert * auto fix removed for linters commit a947888 Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:35:25 2023 +0530 Using the correct field to show toplist delta (#2725) * Using the correct field to show toplist delta * Fixing tests commit 3edadcf Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:31:34 2023 +0530 Call goto once for the same state (#2723) * Update navigation + add example files * Revert "Squashed commit of the following:" This reverts commit 997cc0f.
djbarnwal
added a commit
that referenced
this pull request
Aug 3, 2023
* Remove usage of appStore * Add missing navigation event * Fix types * Add comment * Add cloud dashboard route to telemetry * Use a tag for link * Remove comment
djbarnwal
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Squashed commit of the following: commit 0e69153 Author: Eric P Green <[email protected]> Date: Wed Jul 12 14:57:22 2023 -0400 Handle "repository not found" error (#2769) commit df483d7 Author: Speros Kokenes <[email protected]> Date: Wed Jul 12 09:21:54 2023 -0500 fix: Filters bar not rendering search results properly (#2759) * fix: item rendering, flashing * comment * fix: search bug; tests * feat: move activeColumn def commit b6f4ee3 Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:44:00 2023 +0530 DuckDB sql parser (#2745) * Basic AST traversal * Adding basic table rewrite * Adding basic limit rewrite * Use native json and support CTE and Unions * Adding basic column extraction * Adding basic annotion parser * Sources sql prototype * Adding column expression parsing * Addressing PR comments * Revert prototype code commit be5ce9f Author: Aditya Hegde <[email protected]> Date: Wed Jul 12 19:02:05 2023 +0530 Adding batching API (#2716) * Adding batching API * Adding tests and PR comments * Addressing PR comments commit 6c27aac Author: Speros Kokenes <[email protected]> Date: Tue Jul 11 14:31:14 2023 -0500 feat: app business model context (#2704) * feat: init context sharing * example * fix: lint issue * cleanup * feat: rename business model to state managers commit 5565678 Author: Hamilton Ulmer <[email protected]> Date: Tue Jul 11 12:20:59 2023 -0700 removes render condition from totalsQuery (#2766) commit 0cc1c72 Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 16:45:59 2023 +0200 Enforce export limits only on cloud (#2762) * Enforce export limits only on cloud * Revert MetricsViewRows limit to int32 * Regenerate Orval * Fix missing underscore in filename * Nit commit e3d57b1 Author: bcolloran <[email protected]> Date: Tue Jul 11 07:38:31 2023 -0700 add command to smoketest storybook (#2671) commit 16ad755 Author: Anshul Khandelwal <[email protected]> Date: Tue Jul 11 15:05:45 2023 +0530 motherduck docs (#2752) * motherduck docs * motherduck docs commit 1cf7dec Author: Benjamin Egelund-Müller <[email protected]> Date: Tue Jul 11 11:32:31 2023 +0200 Runtime: Add available_time_zones to dashboard YAML (#2764) commit cb09fb2 Author: Hamilton Ulmer <[email protected]> Date: Mon Jul 10 10:50:44 2023 -0700 YAML editor; integration into `/dashboard/<name>/edit` (#2639) * work out placeholder text * update placeholder to enable auto-generating * adds in skeleton and bootstrap functions to placeholder * renames components * fix overflow issues in new metrics editor * remove all error state when buffer is empty * move editor plugins around * update Placeholder.svelte * adds link to documentation in metrics inspector * move doc link * self-review * update package.json to move to devDependencies * spacing on docs link * center align doc link * remove unused var * remove doc link from inspector * minor refactors to code org for extensions * adds slight debounce to state update function for line levels * move to queryClient.fetchQuery in placeholder model bootstrap * update component structure; move status updates to MetricsWorkspace.svelte * moves basic extensions to base.ts * adds a way to annotate an editor buffer update so we can either add or remove debouncing updates * establishes line number gutter marker, and breaks out the gutters for the line statuses into two distinct entities * fix debounce situation when document is empty * block button nav to dashboard if invalid config * adds create-debouncer.ts, which is a simpler debouncer that operates on the end of a debounced sequence, not the beginning * add story for generic YAML editor, including option for adding line errors * rename files; change Portal implementation since we presume this is all browser-only, which helps with Storybook * adds line number gutter test * add line status gutter tests * adds line status highlighter tests * adds basic tests for indent-guide extension * fix lint error in GoToDashboardButton.svelte * remove unused metrics editor files; fix types * remove unneeded logic from EditorContainer.svelte * shifts around logic to be per-surface * refine reconciliation debouncing * add basic model summary info to metrics inspector based on feedback * fix line level error coloring * adapts e2e tests and adds a new empty metrics flow * switches debounce annotation to be a boolean * fix minor prettier errors * revert useTestServer.ts * fix line-number-gutter.spec.ts * fix YAMLEditor.spec.ts * refine placeholder code * streamlines and fixes codemirror dependencies; removes old codemirror package code from web-local * moves to metrics editor container; re-instates other dashboard tests that were skipped before * fix lint error * moves metrics def errors function to file-artifacts-store.ts and makes it generic for any file type * rename function for file artifact reconciliation errors * move errors to common place for metrics-view * remove unneeded flex which was causing metrics editor to mount halfway down * fix story lint errors * re-adds storybook editor view * fix line selection color compositing * address feedback comments * removes mismatch between line errors and reconciled yaml file * remove console..og commit 5ffc41d Author: Marissa Gorlick <[email protected]> Date: Sun Jul 9 14:30:25 2023 -0500 release notes 0.29 (#2756) Co-authored-by: Marissa Gorlick <[email protected]> commit 7a454b1 Author: Aditya Hegde <[email protected]> Date: Sun Jul 9 18:58:54 2023 +0530 Fix 1st time state being overriden (#2755) commit 54320f7 Author: Anshul Khandelwal <[email protected]> Date: Fri Jul 7 13:56:48 2023 +0530 Motherduck connector preflight APIs (#2746) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set * motherduck preflight apis * md preflight api --------- Co-authored-by: Aditya Hegde <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 31688e2 Author: Rakesh Sharma <[email protected]> Date: Fri Jul 7 13:29:56 2023 +0530 Implement deployment hibernation (#2363) * initial commit * added func to check for expired deployments and de-provision them * fmt * go mod tidy * review changes * hibernation deployment job * small changes * TriggerReprovision added * fix unused opts in admin.go * Add status chip for `HIBERNATED` state * review changes * merging issue * hibernation job time * nit * review changes * reverted ui changes for hibernation * nit * review changes * added sync.WaitGroup for flusher * Review * Run prettier * Review part 2 * Move logic to a custom hook * Add redirect for all routes under `/org/project` --------- Co-authored-by: Eric P Green <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 2bca601 Author: Aditya Hegde <[email protected]> Date: Fri Jul 7 13:23:17 2023 +0530 Use trylock for populating parents/children in catalog queries (#2747) commit 3d105ab Author: Anshul Khandelwal <[email protected]> Date: Thu Jul 6 23:24:36 2023 +0530 Motherduck connector (#2739) * motherduck connector * error checking * review comments * db prop in sources * safe name * hide motherduck tab * Adding motherduck to the tabs * Removing typo * Removing empty uri * hide motherduck if env not set --------- Co-authored-by: Aditya Hegde <[email protected]> commit 7d27a4d Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 19:46:54 2023 +0200 Remove measures length validation from toplist APIs (#2748) commit 41fa1fc Author: Benjamin Egelund-Müller <[email protected]> Date: Thu Jul 6 18:33:43 2023 +0200 Add dashboard YAML property for percent of total (#2590) * Add dashboard YAML property for percent of total * Change to valid_percent_of_total commit df0b53f Author: Speros Kokenes <[email protected]> Date: Thu Jul 6 03:47:32 2023 -0400 wait for process to end (#2550) commit 41b52e4 Author: bcolloran <[email protected]> Date: Wed Jul 5 11:11:04 2023 -0700 button group Component (#2625) * adding stories for buttons, and adding mock svelteKit $app/environment in storybook * cleanup * create ButtonToggleGroup.svelte (empty) * fix package-lock.json * rebuilding package-lock.json again * try package-lock again * try updating vite.config.ts to fix build * revert package-lock to match main * remove fixme comment * start button group stories * initial work on button groups * Button group implemented and stories for button group provided * cleanup and doc * Fix defaultselection handling and improve stories * add tooltips, update stories * update doc * cleanup and rename * fix divider * fix prettier * another prettier fix * another prettier fix * yet another prettier fix * Even more prettier fixes * rework buttonToggleGroup component to be fully controlled * rename component as "ButtonGroup" since it doesn't handle its own toggle state * rename stories file * update story table padding * TS+lint+prettier cleanups * update "test:watch", vitest runs in watch mode by default * update vite config to mock $app/environment for testing * adding first set of tests * add tests * lint fix * update readme commit 480ead7 Author: Rakesh Sharma <[email protected]> Date: Wed Jul 5 19:06:30 2023 +0530 Implement DB size estimation for DuckDB (#2742) * added EstimateSize in OLAPStore * review changes commit 00130c2 Author: Benjamin Egelund-Müller <[email protected]> Date: Wed Jul 5 15:23:50 2023 +0200 Scaffolding of DuckDB SQL utils needed for async reconcile (#2731) commit d41c928 Author: Egor Riashin <[email protected]> Date: Wed Jul 5 10:48:30 2023 +0300 Arbitrary SQL (#2702) * arbitrary SQL * proto * custom-query * custom-query * custom-query * custom-query * custom query tests * custom query * custom query * custom query * custom query * arbitrary-sql * custom query * custom query * proto * non-recursive --------- Co-authored-by: egor-ryashin <[email protected]> commit 1453d9b Author: Eric P Green <[email protected]> Date: Tue Jul 4 15:06:35 2023 -0400 Remove embedded sources from Source UI (#2738) * Remove embedded sources from Source Catalog UI * Colocate embedded source code * Fix `svelte-check` * Remove link * Remove tooltip commit 31149b8 Author: Rakesh Sharma <[email protected]> Date: Tue Jul 4 18:50:41 2023 +0530 Check if provided sources exists for reconcile refresh sources (#2741) * check if provided sources exists for reconcile refresh sources * review changes commit 744f6c7 Author: Dhiraj Barnwal <[email protected]> Date: Tue Jul 4 17:22:41 2023 +0530 Deprecate app store in favor of derived store (#2710) * Remove usage of appStore * Add missing navigation event * Fix types * Add comment * Add cloud dashboard route to telemetry * Use a tag for link * Remove comment commit 0746566 Author: Rohith Reddy Kota <[email protected]> Date: Tue Jul 4 17:11:35 2023 +0530 docs: update import-data (#2721) * docs: update import-data * docs: update import-data commit 4d4c5e0 Author: Aditya Hegde <[email protected]> Date: Tue Jul 4 17:08:55 2023 +0530 Updating timeseries API to new validations (#2740) commit 4a9b8e5 Author: Eugene Sevastianov <[email protected]> Date: Mon Jul 3 19:38:19 2023 +0400 Rate limiting (per operation, per auth/ip) (#2640) * 2347: Admin/Runtime: Rate limiting (per operation, per auth/ip) * Provided descriptions for key structs * Refactored according to PR comments * Limiter interface * Fixed formatting * Fixed tests * Updated func declarations according the lint * Changed LimiterHTTPHandler visibility * Made limit checks more explicit by materializing them in respective packages * Added a request to Metadata so that it is available in a handler * Fixed linter errors * Fixed linter errors * added zap.Error(err) * Reverted auto-IDE change * Added a comment * Simplified by using grpc_auth.UnaryServerInterceptor * Tripled rate limits before we have real numbers measured by a usage tracking * Reverted auto change * check if claims == nil --------- Co-authored-by: e.sevastyanov <[email protected]> Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 3e8090a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 20:28:24 2023 +0530 Search and get project support for support users (#2691) * search and get project support for superusers * review changes * review changes * pr changes * Update admin/server/projects.go * Update admin/server/projects.go --------- Co-authored-by: Benjamin Egelund-Müller <[email protected]> commit 48ae852 Author: Benjamin Egelund-Müller <[email protected]> Date: Mon Jul 3 16:32:47 2023 +0200 CLI: Print suggestions when trying to deploy an existing project (#2689) * CLI: Print suggestions when trying to deploy an existing project * Address review comment commit 507bf57 Author: Speros Kokenes <[email protected]> Date: Mon Jul 3 10:18:36 2023 -0400 feat: export button on dashboard (#2667) * feat: export button on dashboard * feat: move button to drawer lid * fix: lint errors * feat: e2e test, date picker fix * fix: lint issues commit 5d2691a Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:19:37 2023 +0530 2649 cli implement whoami command (#2674) * 2649-cli-implement-whoami-command * added whoami cmd * review changes * nit changes commit eea5652 Author: Egor Riashin <[email protected]> Date: Mon Jul 3 16:48:01 2023 +0300 Additional queries validation (#2712) * queries validation * queries validation * queries validation * queries validation * proto.validate --------- Co-authored-by: Egor Ryashin <[email protected]> commit 9a6a2f4 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:16:56 2023 +0530 Admin: email invite redirect to signup (#2720) * admin redirect to signup * nit * review changes commit 4c7b069 Author: Dhiraj Barnwal <[email protected]> Date: Mon Jul 3 19:05:25 2023 +0530 Show sign up auth page when suggested (#2722) commit 6154524 Author: Rakesh Sharma <[email protected]> Date: Mon Jul 3 19:04:27 2023 +0530 Auto fix removed for linters (#2727) * linter fail * revert * auto fix removed for linters commit a947888 Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:35:25 2023 +0530 Using the correct field to show toplist delta (#2725) * Using the correct field to show toplist delta * Fixing tests commit 3edadcf Author: Aditya Hegde <[email protected]> Date: Mon Jul 3 11:31:34 2023 +0530 Call goto once for the same state (#2723) * Update navigation + add example files * Revert "Squashed commit of the following:" This reverts commit 997cc0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
Issue addressed:
Uses
pagestore from sveltekit to derive active entityAdds missing navigation events