Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RXI-1136 allow multi commits with the same claimID #111

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

oleks-rip
Copy link
Collaborator

@oleks-rip oleks-rip commented Jun 15, 2024

There are can be multiple commits with different amount but the same ClaimID. After attestation only last one commit will be applied.

@sgramkumar
Copy link

This fixes the issue on multiple XChainCommit

Copy link
Contributor

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 left a minor nit, but also OK as-is.

// transaction
};

namespace mi = boost::multi_index;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be in a header file - it has too wide of a scope.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed ae89cf2

remove namespace alias
@oleks-rip oleks-rip force-pushed the multi_commits branch 2 times, most recently from c1de51b to 23610d9 Compare June 18, 2024 21:12
Added more logs
Added mutex for console output
@oleks-rip oleks-rip merged commit c882220 into ripple:develop Jun 18, 2024
10 checks passed
@oleks-rip oleks-rip deleted the multi_commits branch June 18, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants