fix: remove schema.registry.name.strategy #2660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
approved these changes
Sep 30, 2024
| @@ -64,7 +58,6 @@ Syntax: | |||
| FORMAT PLAIN | |||
| ENCODE AVRO ( | |||
| schema.registry = 'schema_registry_url [, ...]', | |||
| [schema.registry.name.strategy = 'topic_name_strategy'], | |||
| [message = 'main_message'], | |||
There was a problem hiding this comment.
For avro (but not protobuf), message is only useful when record_name_strategy or topic_record_name_strategy. It shall be removed as well.
| @@ -96,7 +87,6 @@ FORMAT DEBEZIUM | |||
| ENCODE AVRO ( | |||
| message = 'main_message', | |||
| schema.location = 'location' | schema.registry = 'schema_registry_url [, ...]', | |||
| [schema.registry.name.strategy = 'topic_name_strategy'], | |||
| [key.message = 'test_key'], | |||
There was a problem hiding this comment.
Same here. Let's remove both message and key.message for Debezium Avro.
Btw schema.location shall not be here for avro either. It has to be schema.registry.
| Syntax: | ||
|
|
||
| ```sql | ||
| FORMAT UPSERT | ||
| ENCODE AVRO ( | ||
| schema.location = 'location' | schema.registry = 'schema_registry_url [, ...]', | ||
| [schema.registry.name.strategy = 'topic_name_strategy'], | ||
| [message = 'main_message'], |
There was a problem hiding this comment.
message no longer useful
WanYixian
approved these changes
Sep 30, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we do not need
schema.registry.name.strategybecause now we no longer get key schema from schema registry.Keeping the default behavior to
<topic name>-valueas value schema subjectRelated code PR
Related doc issue
Resolve
Rendered preview
Checklist
emile-00,hengm3467, &WanYixian).