-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DROP DATABASE
doesn't clean up the source stream job (in v1)
#18033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
changed the title
fix drop database for shared source
fix: fix 2 shared source bugs
Aug 14, 2024
9 tasks
xxchan
commented
Aug 14, 2024
xxchan
force-pushed
the
xxchan/drop-db
branch
from
September 2, 2024 06:04
323feeb
to
15d8287
Compare
xxchan
changed the title
fix: fix 2 shared source bugs
fix: Sep 2, 2024
DROP DATABASE
doesn't clean up the source stream job
xxchan
changed the title
fix:
fix: Sep 2, 2024
DROP DATABASE
doesn't clean up the source stream jobDROP DATABASE
doesn't clean up the source stream job (in v1)
yezizp2012
reviewed
Sep 2, 2024
Signed-off-by: xxchan <[email protected]>
This reverts commit 15d8287.
xxchan
force-pushed
the
xxchan/drop-db
branch
from
September 3, 2024 06:30
8f0f545
to
1854392
Compare
yezizp2012
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
DROP DATABASE
doesn't clean up the source stream jobChecklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.