-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change streaming upload timeout to 20s only for backfill test #18652
Merged
wcy-fdu
merged 13 commits into
main
from
wcy/change_backfill_test_streaming_upload_timeout
Sep 26, 2024
Merged
chore: change streaming upload timeout to 20s only for backfill test #18652
wcy-fdu
merged 13 commits into
main
from
wcy/change_backfill_test_streaming_upload_timeout
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: MrCroxx <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 5408 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
2302 | 1 | 3105 | 0 |
Click to see the invalid file list
- src/connector/src/parser/protobuf/recursive.rs
Signed-off-by: MrCroxx <[email protected]>
hzxa21
reviewed
Sep 25, 2024
hzxa21
reviewed
Sep 25, 2024
hzxa21
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
…ttps://github.com/risingwavelabs/risingwave into wcy/change_backfill_test_streaming_upload_timeout
wcy-fdu
deleted the
wcy/change_backfill_test_streaming_upload_timeout
branch
September 26, 2024 09:37
github-actions bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…18652) Signed-off-by: MrCroxx <[email protected]> Co-authored-by: MrCroxx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, wait for #18693
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.