Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change streaming upload timeout to 20s only for backfill test #18652

Merged
merged 13 commits into from
Sep 26, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Sep 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, wait for #18693

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from a team as a code owner September 24, 2024 10:57
@wcy-fdu wcy-fdu requested a review from lmatz September 24, 2024 10:57
@MrCroxx MrCroxx requested review from MrCroxx and removed request for lmatz September 24, 2024 11:00
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5408 files.

Valid Invalid Ignored Fixed
2302 1 3105 0
Click to see the invalid file list
  • src/connector/src/parser/protobuf/recursive.rs

src/connector/src/parser/protobuf/recursive.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/config/ci.toml Outdated Show resolved Hide resolved
@graphite-app graphite-app bot requested a review from a team September 26, 2024 06:22
@wcy-fdu wcy-fdu requested a review from hzxa21 September 26, 2024 06:29
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

risedev.yml Outdated Show resolved Hide resolved
risedev.yml Outdated Show resolved Hide resolved
risedev.yml Outdated Show resolved Hide resolved
@wcy-fdu wcy-fdu added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 647b37e Sep 26, 2024
30 of 32 checks passed
@wcy-fdu wcy-fdu deleted the wcy/change_backfill_test_streaming_upload_timeout branch September 26, 2024 09:37
github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants