Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): show job's max parallelism in system tables #18672

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Sep 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a progress towards #15900. Sequel to #18740.

Allow users to inspect max parallelism through system tables.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao force-pushed the bz/var-vnode-user-facing-local_split branch from e29b738 to 4e93810 Compare September 24, 2024 09:20
@BugenZhao BugenZhao force-pushed the bz/var-vnode-user-facing-local_split branch from 4e93810 to a3a5472 Compare September 24, 2024 09:37
@BugenZhao BugenZhao force-pushed the bz/var-vnode-system-tables branch 2 times, most recently from 1aaa9da to bad2ea5 Compare September 26, 2024 08:02
Base automatically changed from bz/var-vnode-user-facing-local_split to main September 26, 2024 10:10
@BugenZhao BugenZhao changed the base branch from main to bz/persist-max-parallelism September 26, 2024 10:58
@BugenZhao BugenZhao force-pushed the bz/var-vnode-system-tables branch 2 times, most recently from 107bc05 to 1509b47 Compare September 26, 2024 11:03
@BugenZhao BugenZhao force-pushed the bz/var-vnode-system-tables branch 2 times, most recently from 9a150ce to 5b451cb Compare September 27, 2024 09:12
@BugenZhao BugenZhao changed the title feat(frontend): show max parallelism (vnode count) in system tables feat(frontend): include job's max parallelism in system tables Sep 27, 2024
@BugenZhao BugenZhao changed the title feat(frontend): include job's max parallelism in system tables feat(frontend): show job's max parallelism in system tables Sep 27, 2024
@BugenZhao BugenZhao marked this pull request as ready for review September 27, 2024 10:06
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update the integration test test_shared_source as well.

@BugenZhao
Copy link
Member Author

BugenZhao commented Sep 29, 2024

LGTM, please update the integration test test_shared_source as well.

Done. Would you also review the pre-requisite (#18740)? 🥺

Base automatically changed from bz/persist-max-parallelism to main September 29, 2024 10:16
@BugenZhao BugenZhao added this pull request to the merge queue Sep 30, 2024
@graphite-app graphite-app bot requested a review from a team September 30, 2024 03:33
Merged via the queue into main with commit f7e5068 Sep 30, 2024
32 of 34 checks passed
@BugenZhao BugenZhao deleted the bz/var-vnode-system-tables branch September 30, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants