-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): show job's max parallelism in system tables #18672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local_split
branch
from
September 24, 2024 09:20
e29b738
to
4e93810
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 24, 2024 09:21
0b9aca4
to
b2c0f49
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local_split
branch
from
September 24, 2024 09:37
4e93810
to
a3a5472
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
2 times, most recently
from
September 26, 2024 08:02
1aaa9da
to
bad2ea5
Compare
Base automatically changed from
bz/var-vnode-user-facing-local_split
to
main
September 26, 2024 10:10
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 26, 2024 10:58
bad2ea5
to
4acc6a8
Compare
Merged
4 tasks
BugenZhao
force-pushed
the
bz/persist-max-parallelism
branch
from
September 26, 2024 10:59
8cfaf3f
to
bad6ee3
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
2 times, most recently
from
September 26, 2024 11:03
107bc05
to
1509b47
Compare
BugenZhao
force-pushed
the
bz/persist-max-parallelism
branch
from
September 27, 2024 06:46
bad6ee3
to
2587bb0
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 27, 2024 06:46
1509b47
to
b02811d
Compare
BugenZhao
force-pushed
the
bz/persist-max-parallelism
branch
from
September 27, 2024 08:34
2587bb0
to
612a489
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
2 times, most recently
from
September 27, 2024 09:12
9a150ce
to
5b451cb
Compare
BugenZhao
force-pushed
the
bz/persist-max-parallelism
branch
from
September 27, 2024 09:38
ecf3a25
to
8a4481c
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 27, 2024 09:39
5b451cb
to
4a04f82
Compare
BugenZhao
changed the title
feat(frontend): show max parallelism (vnode count) in system tables
feat(frontend): include job's max parallelism in system tables
Sep 27, 2024
BugenZhao
changed the title
feat(frontend): include job's max parallelism in system tables
feat(frontend): show job's max parallelism in system tables
Sep 27, 2024
BugenZhao
force-pushed
the
bz/persist-max-parallelism
branch
from
September 29, 2024 05:20
8a4481c
to
9736d32
Compare
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 29, 2024 05:20
4a04f82
to
0e014a6
Compare
yezizp2012
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please update the integration test test_shared_source
as well.
4 tasks
Done. Would you also review the pre-requisite (#18740)? 🥺 |
9 tasks
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 29, 2024 09:21
c2f007c
to
7a83d1a
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/var-vnode-system-tables
branch
from
September 30, 2024 03:05
7a83d1a
to
07ec687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900. Sequel to #18740.
Allow users to inspect max parallelism through system tables.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.