Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): add json encode for file sink #18744

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

add fs sink json encode test

944bf12
Select commit
Loading
Failed to load commit list.
Open

feat(sink): add json encode for file sink #18744

add fs sink json encode test
944bf12
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-09-30 06:46:28 ago

2 / 9 tasks completed

7 tasks still to be completed

Details

Required Tasks

Task Status
in snowflake sink, the file name contains a uuid to distinguish the parallelism, while the file sink directly uses executor_id. Incomplete
in snowflake sink, there are no line breaks between lines, but the file sink has.(I think it's more friendly with user) Incomplete
add e2e/ci test. Completed
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Incomplete
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Completed