Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(risedev): fix log check and startup failure for postgres #18745

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Sep 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Here is the log when launching the Postgres container for the first time:

waiting for server to start....2024-09-27 07:42:09.361 UTC [114] LOG:  starting PostgreSQL 17.0 on arm-unknown-linux-musleabihf, compiled by gcc (Alpine 13.2.1_git20240309) 13.2.1 20240309, 32-bit
2024-09-27 07:42:09.370 UTC [114] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2024-09-27 07:42:09.386 UTC [122] LOG:  database system was shut down at 2024-09-27 07:42:09 UTC
2024-09-27 07:42:09.405 UTC [114] LOG:  database system is ready to accept connections
 done
server started
CREATE DATABASE


/usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/*

waiting for server to shut down...2024-09-27 07:42:09.825 UTC [114] LOG:  received fast shutdown request
.2024-09-27 07:42:09.828 UTC [114] LOG:  aborting any active transactions
2024-09-27 07:42:09.838 UTC [114] LOG:  background worker "logical replication launcher" (PID 128) exited with exit code 1
2024-09-27 07:42:09.839 UTC [118] LOG:  shutting down
2024-09-27 07:42:09.840 UTC [118] LOG:  checkpoint starting: shutdown immediate
2024-09-27 07:42:10.203 UTC [118] LOG:  checkpoint complete: wrote 923 buffers (5.6%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.051 s, sync=0.300 s, total=0.363 s; sync files=301, longest=0.011 s, average=0.001 s; distance=4249 kB, estimate=4249 kB; lsn=0/1910620, redo lsn=0/1910620
2024-09-27 07:42:10.217 UTC [114] LOG:  database system is shut down
 done
server stopped

PostgreSQL init process complete; ready for start up.

2024-09-27 07:42:10.395 UTC [1] LOG:  starting PostgreSQL 17.0 on arm-unknown-linux-musleabihf, compiled by gcc (Alpine 13.2.1_git20240309) 13.2.1 20240309, 32-bit
2024-09-27 07:42:10.398 UTC [1] LOG:  listening on IPv4 address "0.0.0.0", port 5432
2024-09-27 07:42:10.398 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2024-09-27 07:42:10.408 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2024-09-27 07:42:10.423 UTC [153] LOG:  database system was shut down at 2024-09-27 07:42:10 UTC
2024-09-27 07:42:10.442 UTC [1] LOG:  database system is ready to accept connections

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs

@xxchan
Copy link
Member

xxchan commented Sep 27, 2024

Is the link wrong?

@yezizp2012
Copy link
Contributor

Is the link wrong?

fixed.

@BugenZhao BugenZhao added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 1ddf30e Sep 27, 2024
34 of 35 checks passed
@BugenZhao BugenZhao deleted the bz/risedev-postgres-log-check branch September 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./risedev d full encounters: ERROR - Failed to start: failed to wait for service postgres-8432 to be ready
4 participants