Cleanup for partial borrowers notebook #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial borrower csv files are still referenced, so I moved them back into the data directory.
Renamed and cleaned up about the first half of this notebook. Added missing dependencies to requirements.txt and that notebook is now added to unit tests and passing with treon.
Refactored my altair raincloud plot into a reusable method and added to
utils.charts; updated partial borrowers and hemingway notebook to use it.This is branched from the hemingway raincloud plot branch; review and merge #13 first, and make sure to merge with a regular merge commit. Once that is merged, I think github should automatically update this one to merge to main.