Patch for android compilation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add FileType::Socket which maps to S_IFSOCK
…ons ourself anymore)
…mpiler (also fixes ARM compilation, fixes zargony#63)
…tions in examples by turning on logging, e.g. with `RUST_LOG=debug`
Add basic fuse opt parse
Manage all kernel opt
roblabla
requested changes
Sep 4, 2017
| @@ -26,6 +27,8 @@ pub struct Channel { | |||
| fd: c_int, | |||
| } | |||
|
|
|||
| use fuse::fuse_mount_compat25; | |||
| @@ -526,3 +517,221 @@ pub struct fuse_dirent { | |||
| pub typ: u32, | |||
| // followed by name of namelen bytes | |||
| } | |||
|
|
|||
| #[cfg(feature="rust-mount")] | |||
There was a problem hiding this comment.
tous les #[cfg] la ils sont un peu lourd, faudrait utiliser cfg-if
|
|
||
| use std; | ||
|
|
||
| mod sys { |
There was a problem hiding this comment.
mets le cfg(not) sur le mod plutot que sur tous les enfants.
| mount(c_sources.as_ptr(), c_mnt.as_ptr(), c_fs.as_ptr(), flags, c_opts.as_ptr() as *mut c_void) | ||
| }; | ||
| if res < 0 { | ||
| return res; |
There was a problem hiding this comment.
Ce serait pas mal de renvoyer un Result<RawFd, i32> plutot, et du coup de renvoyer errno ici plutot. Ca permettrais de rendre le code plus rusty.
| } | ||
|
|
||
| // /usr/include/sys/mount.h | ||
| const MS_NOSUID :u64 = 2; |
There was a problem hiding this comment.
Vire-moi ca, c'est defini dans la crate libc.
| // TODO: check if help | ||
| // TODO: get kernel/other flags options | ||
|
|
||
| let mut res = fuse_mount_sys(mountpoint, flags, &mnt_opts); |
There was a problem hiding this comment.
parreil, ce serait pas mal de renvoyer Result<i32, ??>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.