Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxqt-panel #594

Merged
merged 30 commits into from
Nov 4, 2024
Merged

Add lxqt-panel #594

merged 30 commits into from
Nov 4, 2024

Conversation

Besanon
Copy link
Contributor

@Besanon Besanon commented Oct 28, 2024

Panel for lxqt desktop group

first file for the LXQT 2.0 desktop group
starter file for LXQT Desktop
I use sddm as display manager

I cant remove the other file - only use graphical env., sorry

After startlxqt i would add  2 lines to sddm to enable the start of LXQT desktop
Enable sddm to start an lxqt desktop session
lxqt-session to be started by startlxqt. Display manager: sddm
is needed for several complaints:
DENIED  kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open /usr/share/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED  kscreen_backend_launcher open /usr/share/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
Comment on lines 34 to 35
/usr/lib{,32,64}/lxqt-panel/*.so mr, # LXQT-Plugins
/usr/lib{,32,64}/lxqt-config/*.so mr, # LXQT-Plugins
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use @{lib} instead of /usr/lib{,32,64}

owner @{user_config_dirs}/pulse/{,**} rwk,
owner @{user_config_dirs}/ibus/bus/{,**} rw,

@{run}/udev/data/* r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That need to be restricted. Take a look at how it is used in the profiles. You usually only need to copy/paste existing rule from other profiles.

Comment on lines 53 to 59
owner @{HOME}/.config/menus/*.menu rw,
owner @{HOME}/.config/menus/applications-merged/ r,
owner @{HOME}/Desktop/*.desktop rw,
owner @{HOME}/Desktop/#@{int} rw,
owner @{HOME}/Desktop/*.desktop l -> @{HOME}/Desktop/#@{int},
owner @{HOME}/.local/share/desktop-directories/*.directory r,
owner @{HOME}/.local/share/gvfs-metadata/{,*} r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use the tunables such as @{user_config_dirs} cf https://apparmor.pujol.io/variables/

owner @{HOME}/.local/share/desktop-directories/*.directory r,
owner @{HOME}/.local/share/gvfs-metadata/{,*} r,

owner @{user_config_dirs}/lxqt/#* rw,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be: @{user_config_dirs}/lxqt/#@{int} (same elsewhere)

/usr/share/lxqt/helpers/*.desktop r,
/usr/share/lxqt/panel/plugins/{,*.desktop} r,
/usr/share/desktop-directories/{,**} r,
/usr/share/X11/locale/locale.alias r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/usr/share/X11/ is part of the lxqt abstraction.

Comment on lines 37 to 38
/usr/share/lxqt/helpers/*.desktop r,
/usr/share/lxqt/panel/plugins/{,*.desktop} r,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify as /usr/share/lxqt/{,**}

@roddhjav
Copy link
Owner

There is an issue between:

  • abstractions/app-launcher-user
  • @{bin}/exo-open rix,
  • @{bin}/xdg-open rPx,

Both exo & xdg are part of @{open_path}. They should be handled the same way.

See: https://apparmor.pujol.io/development/internal/#open-resources for more.

@Besanon
Copy link
Contributor Author

Besanon commented Oct 29, 2024

what crashed the first test?

@Besanon
Copy link
Contributor Author

Besanon commented Oct 29, 2024

ok, the new altered version is working without complaints in Arch linux

add child-open
you think its too permissive to have app-launcher-user here, right?
add needed programs
turning back to layout of corresponding xfce file.
@roddhjav roddhjav merged commit 026fbf7 into roddhjav:main Nov 4, 2024
6 checks passed
@roddhjav
Copy link
Owner

roddhjav commented Nov 4, 2024

Thanks, it looks good now. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants