Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect bundle id on Rollbar Demo #336

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fixed incorrect bundle id on Rollbar Demo #336

merged 1 commit into from
Aug 23, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 23, 2023

Description of the change

This PR fixes the Rollbar Demo's bundle identifier that wasn't correctly from the old project when it was recreated to support lower minimum deployable versions.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 23, 2023
@matux matux merged commit c2b6a51 into master Aug 23, 2023
1 check passed
@matux matux deleted the bundle_id branch August 23, 2023 17:27
@matux matux mentioned this pull request Feb 13, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants