Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation issue in Xcode 16 Beta due to a missing #include #353

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

progrmr
Copy link

@progrmr progrmr commented Aug 9, 2024

Description of the change

File RollbarCrashMachineContext.c not compiling with Xcode 16 beta 5, error: ucontext64_t was undefined.
Added #include <sys/_types/_ucontext64.h> to fix.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link
Collaborator

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this fixes the compilation issue. Thank you @progrmr!

@matux matux merged commit e56f3e1 into rollbar:master Aug 16, 2024
1 check passed
@matux matux changed the title added #include needed Fixed compilation issue in Xcode 16 Beta due to a missing #include Aug 16, 2024
@matux matux linked an issue Aug 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollbar won't compile for a Swift Mac OS app
2 participants