Fix for navigation bar when scaling UINavigationController's view in iOS 11 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntViewController in iOS 11
|
i tested the raw code at my end and it works perfectly, thank you. |
fabricemasachs
approved these changes
Jan 1, 2018
|
if its fine merge it, please. don't hesitate. |
gastonmorixe
reviewed
Apr 3, 2018
| @@ -649,9 +667,11 @@ - (void)panGestureRecognized:(UIPanGestureRecognizer *)recognizer | |||
| CGFloat oppositeScale = (1 - (contentViewScale - 1)); | |||
| self.contentViewContainer.transform = CGAffineTransformMakeScale(oppositeScale, oppositeScale); | |||
| self.contentViewContainer.transform = CGAffineTransformTranslate(self.contentViewContainer.transform, point.x, 0); | |||
| [self updateContentViewAdditionalSafeAreaInsets]; | |||
| } else { | |||
| self.contentViewContainer.transform = CGAffineTransformMakeScale(contentViewScale, contentViewScale); | |||
There was a problem hiding this comment.
I have found that scaling layer.transform instead of view.transform does not cause this bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303 by adjusting safe area insets during animations