Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang] Fix crash with constexpr destructor #13859

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[clang] Fix crash with constexpr destructor #13859

merged 1 commit into from
Oct 17, 2023

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Oct 13, 2023

@hahnjo hahnjo self-assigned this Oct 13, 2023
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

Test Results

       12 files         12 suites   1d 22h 20m 12s ⏱️
  2 483 tests   2 482 ✔️ 0 💤 1 ❌
28 680 runs  28 679 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit c344bd7.

♻️ This comment has been updated with latest results.

Axel-Naumann
Axel-Naumann approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, it works!

@hahnjo hahnjo marked this pull request as ready for review October 16, 2023 11:51
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@vgvassilev
Copy link
Member

Let’s wait for this to land upstream.

@hahnjo
Copy link
Member Author

hahnjo commented Oct 16, 2023

Let’s wait for this to land upstream.

Is this a requirement? This is finally fixing test crashes with the most recent GCC and C++20, I'd rather have this in...

@vgvassilev
Copy link
Member

Let’s wait for this to land upstream.

Is this a requirement? This is finally fixing test crashes with the most recent GCC and C++20, I'd rather have this in...

Do we have a open PR against the llvm mainstream at least?

@hahnjo
Copy link
Member Author

hahnjo commented Oct 16, 2023

Let’s wait for this to land upstream.

Is this a requirement? This is finally fixing test crashes with the most recent GCC and C++20, I'd rather have this in...

Do we have a open PR against the llvm mainstream at least?

Yes, llvm/llvm-project#69076, as linked from the LLVM issue

@vgvassilev
Copy link
Member

Ok, I missed that.

vgvassilev
vgvassilev approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hahnjo hahnjo merged commit 0919a53 into root-project:master Oct 17, 2023
15 of 17 checks passed
@hahnjo hahnjo deleted the gcc13-cxx20 branch October 17, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees

@hahnjo hahnjo

Labels
in:Cling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test crash with GCC 13 and C++20
4 participants
@hahnjo @phsft-bot @vgvassilev @Axel-Naumann