[RF] Move RooFit pythonizations to roofit and make them pip installable #16608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
lmoneta,
couet,
dpiparo and
vepadulano
as code owners
guitargeek
changed the title
Test Results 17 files 17 suites 4d 3h 56m 15s ⏱️ For more details on these failures, see this check. Results for commit a77b9a9. ♻️ This comment has been updated with latest results. |
This will help with more modular RooFit builds, and it's also a big step towards making the RooFit developer experience for the pythonizations more pleasant. The goal is that people can contribute to the RooFit pythonizations without having to interact with any CMake or C++ compilation, which was requested by our power users. Testing changes to the pythonizations is easy now, because they can be installed easily with pip on top of an existing ROOT install, in which case this install will override the RooFit pythonizations shipped with ROOT. This makes developing the pythonizations *much* easier!
guitargeek
force-pushed
the
roofit_pyz
branch
from
42a9dad
to
a77b9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is improving the development workflow, now how users are getting ROOT and RooFit!
This will help with more modular RooFit builds, and it's also a big step
towards making the RooFit developer experience for the pythonizations
more pleasant.
The goal is that people can contribute to the RooFit pythonizations
without having to interact with any CMake or C++ compilation, which was
requested by our power users.
Testing changes to the pythonizations is easy now, because they can be
installed easily with pip on top of an existing ROOT install, in which
case this install will override the RooFit pythonizations shipped with
ROOT.
This makes developing the pythonizations much easier!
A README is added to
roofit/pythonizationsthat outlines the steps as follows:Therefore, the easiest and recommended way to develop RooFit pythonizations is as follows:
roofit/pythonizationsdirectorypip install -e .for an editable install (virtual environment recommended)