Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] Fix column ID order #16621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[ntuple] Fix column ID order #16621

wants to merge 5 commits into from
+105 −28

Commits on Oct 7, 2024

  1. [ntuple] fix buffered, late projection extensions 

    Fix the mirroring of the inner model in the buffered sink. On late model
extension, the buffered sink calls forwards UpdateSchema() to the inner
sink with a derived changeset. In that derived changeset, the field map
for projected fields was mistakenly using the outer models source
fields. Fixed to using the inner models source fields.
    @jblomer
    jblomer committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    16cc693 View commit details
    Browse the repository at this point in the history

  2. [NFC][ntuple] fix column ID order in the specification

    @jblomer
    jblomer committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    06700aa View commit details
    Browse the repository at this point in the history

  3. [ntuple] fix column ID order 

    During serialization and deserialization, issue logical column IDs for
all the physical columns first and only then for the logical IDs.

Since the descriptor is built in "schema update steps", this means that
the logical column IDs of alias columns can still change during schema
construction. The physical column IDs, however, are fix upon passing a
column to the descriptor builder.
    @jblomer
    jblomer committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d42b730 View commit details
    Browse the repository at this point in the history

  4. [ntuple] fix-up in test

    @jblomer
    jblomer committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    acdb92e View commit details
    Browse the repository at this point in the history

  5. [ntuple] simplify/fix ShiftAliasColumns()

    @jblomer
    jblomer committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d98219a View commit details
    Browse the repository at this point in the history