[RF] Fix some memory leaks in Python tutorials #16670
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 14 files 14 suites 3d 10h 29m 44s ⏱️ For more details on these failures, see this check. Results for commit ba617a3. ♻️ This comment has been updated with latest results. |
this fixes the compilation on ubuntu 24.10
The old PyROOT (pre 2019) had a slightly different `atexit` handler than the new one. The hard shutdown mode is different: `ClearProxiedObjects()` is called before the final `gROOT->EndOfProcessCleanups()`. I had the impresstion that this is redundant, and indeed the old PyROOT didn't do it. This commit suggests to only call `ClearProxiedObjects()` in soft shutdown mode, in an attempt to avoid the frequent crashes seen at the end of PyROOT tutorials, especially on Ubuntu 24.10. See also the original PRs where this functionality was introduced: * root-project#4687 * root-project#4753
guitargeek
force-pushed
the
addUbu24_v2
branch
from
0d38fea
to
2eb5c04
Compare
guitargeek
force-pushed
the
addUbu24_v2
branch
from
2eb5c04
to
3b591e5
Compare
guitargeek
force-pushed
the
addUbu24_v2
branch
from
3b591e5
to
ba617a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check if this would fix the Ubuntu 24.10 builds.