Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][ntuple] add clarifying comments #16686

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[NFC][ntuple] add clarifying comments #16686

merged 2 commits into from
Oct 15, 2024

Conversation

jblomer
Copy link
Contributor

@jblomer jblomer commented Oct 15, 2024

Follow-up of #16659

@jblomer jblomer self-assigned this Oct 15, 2024
hahnjo
hahnjo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tree/ntuple/v7/test/ntuple_view.cxx Outdated Show resolved Hide resolved
@jblomer jblomer merged commit 37b3768 into root-project:master Oct 15, 2024
1 check passed
@jblomer jblomer deleted the ntuple-fixup branch October 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahnjo hahnjo hahnjo approved these changes

@pcanal pcanal Awaiting requested review from pcanal

@silverweed silverweed Awaiting requested review from silverweed

@enirolf enirolf Awaiting requested review from enirolf

Assignees

@jblomer jblomer

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jblomer @hahnjo