Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog post about new web graphics #869

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

couet
Copy link
Member

@couet couet commented Jul 6, 2023

New blog post anouncing the new graphics default.

@couet couet requested review from linev and bellenot July 6, 2023 09:00
@linev
Copy link
Member

linev commented Jul 6, 2023

Probably some conclusion is missing. Like:

We encourage all users to try this functionality and give us the feedback!

@couet
Copy link
Member Author

couet commented Jul 6, 2023

@linev @bellenot : I thnik this blog post is ok now. Is it fine for you if I merge this PR ?

@bellenot
Copy link
Member

bellenot commented Jul 6, 2023

I'll take a look and let you know (maybe a couple of details here and there...)

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several small details, but overall it looks OK

ROOT functionality. The look and feel for basic objects, like histograms and graphs, will not
change much – all the drawing options and styles are supported as in the original graphics.
You can compare the two following screen shots made with the same macro – one is original
ROOT graphics, other is web-based one. Try to guess which one where?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ROOT graphics, other is web-based one. Try to guess which one where?
ROOT graphics, other is web-based one.

I think Try to guess which one where? is superfluous

applications on all platforms.

What about image production in batch?
For the moment we keep old functionality, like when running ROOT with the `-b` flag, for image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For the moment we keep old functionality, like when running ROOT with the `-b` flag, for image
For the moment we keep the old functionality, like when running ROOT with the `-b` flag, for image

What about image production in batch?
For the moment we keep old functionality, like when running ROOT with the `-b` flag, for image
production. Web-based canvas will be used for PNG/JPEG/SVG images creation by adding `--web`
flag when running ROOT. While image generation involves running of web browsers in headless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flag when running ROOT. While image generation involves running of web browsers in headless
flag when running ROOT. While image generation involves running web browsers in headless

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@couet couet merged commit 4bd6f13 into root-project:main Jul 7, 2023
3 checks passed
@couet couet deleted the new-blog-post branch July 7, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants