Added gp180 support. #376
Closed
Added gp180 support. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to make some improvements before reopening. |
|
@Doomerdinger: would you be willing to resubmit this? Even if the improvements you refer to would be an approach to resolve #390, it would be good to first merge the basic model here. Solving #390 might take some time. |
|
There were a couple of things, but yes that was one of them. I can reopen this and a couple other arms and such that I have going in the next couple days. My arms do rely on changes I made in PR378 so if I could ask you to take another look at that it'd smooth things out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for GP180.
See #375