Add support for base GP180 variant (rebased #395) #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Seems GH actions is having a bit of a difficult day. |
Closed
|
As I've reviewed the original PR, I'm going to merge this one -- which is essentially just a rebase -- without waiting on a review. |
|
Using a squash-merge again, as we don't want all the fixups to end up in the history. |
|
Thanks again for the work @Doomerdinger 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally had time to rebase this and add some fixups.
Original PR by @Doomerdinger in #395.
Commit provenance retained, rebased on-top of current
kinetic-devel.The
motoman_resourcespart of #395 was already merged as part of #405.Note: I've not re-oriented the
joints, nor thelinks. As such, this variant'sxacro:macrodeviates from all other models in this repository. I did add a note about this to the package's manifest.Afaict, this PR is OK to merge like this.