Install binaries and overlay minor fixups #4369
Conversation
mikaelarguedas
commented
May 6, 2024
mikaelarguedas
commented
- update before upgrading
- fix line number of edit of turtlesim package
source/Tutorials/Beginner-Client-Libraries/Creating-A-Workspace/Creating-A-Workspace.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
install_binaries_fixups
branch
from
d16e926
to
ee233ef
Compare
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
install_binaries_fixups
branch
from
a6bc319
to
84ddab1
Compare
Signed-off-by: Mikael Arguedas <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Mikael Arguedas <[email protected]>
|
|
||
| .. tabs:: | ||
|
|
||
| .. group-tab:: Fast DDS | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds rti-connext-dds-6.0.1 urdfdom_headers" | ||
|
|
||
| .. group-tab:: Cyclone DDS | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds rti-connext-dds-6.0.1 urdfdom_headers" | ||
|
|
||
| .. group-tab:: Connext DDS | ||
|
|
||
| .. code-block:: bash | ||
|
|
||
| rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds urdfdom_headers" |
There was a problem hiding this comment.
I'm not sure I love the group tabs here. The problem is that they are really all very similar, with only one difference.
My suggestion is different. I suggest that we restore line 92 to exactly how it was, and then just add a note that says something like:
.. note::
If you are using Connext-DDS, you should install Connext with `sudo apt-get install rti-connext-dds-6.0.1`.
There was a problem hiding this comment.
The problem is that they are really all very similar, with only one difference.
I saw little of the ROS 2 docs but most tabs I've seen so far were:
For Linux: command A
For macOS: command A
For Windows: command B
This seem very similar to the case here
I suggest that we restore line 92 to exactly how it was, and then just add a note that says something like:
Semantically it's a bit weird to me to says:
Step 1 "Run this long complex command blacklisting what you need"
Step 2 "Now if you need it: run this extra command to manually install the thing you just blacklisted".
There was a problem hiding this comment.
@ahcorde should I apply #4369 (comment) ?
Or can this be merged as is ?
